output_mode should be output_type

Started by Tomonari Katsumataabout 9 years ago2 messagesdocs
Jump to latest
#1Tomonari Katsumata
t.katsumata1122@gmail.com

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/9.6/static/logicaldecoding-output-plugin.html
Description:

Hello.

I found documentation bug.
[47.6.3. Output Modes]
https://www.postgresql.org/docs/9.6/static/logicaldecoding-output-plugin.html#LOGICALDECODING-OUTPUT-MODE

According to this document, "output_mode" parameter is used for changing
output mode. But test_decoding uses "output_type" like below.

--- test_decoding.c ---
 155                 opt->output_type = OUTPUT_PLUGIN_BINARY_OUTPUT;
-----------------------

Sorry for trivial comment, but please fix this!

--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Tomonari Katsumata (#1)
Re: output_mode should be output_type

t.katsumata1122@gmail.com writes:

I found documentation bug.
[47.6.3. Output Modes]
https://www.postgresql.org/docs/9.6/static/logicaldecoding-output-plugin.html#LOGICALDECODING-OUTPUT-MODE

According to this document, "output_mode" parameter is used for changing
output mode. But test_decoding uses "output_type" like below.

Yup, you're right. Surprising that nobody noticed this before ...
thanks for reporting it!

regards, tom lane

--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs