Misleading
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t75901psql -h localhost -U postgresBuilt from patchset v3 (message #3), July 28, 2026 at 02:27 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t75901_3 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t75901_3 && git checkout t75901_3Patchset v3 (message #3) is on t75901_3
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/9.6/static/pgupgrade.html
Description:
Hello,
Please correct following part of pg_upgrade documentation:
`You can also specify user and port values, and whether you want the data
linked instead of copied (the default).`
It is not clear what is the default option. If you read the whole sentence,
then context might be misinterpreted to `data linked instead of copied` is
default but you meant that copying is default. Please correct this as it is
confusing and can lead someone to big troubles.
My suggestion:
- completely omit confusing default word:
`You can also specify user and port values, and whether you want the data
linked instead of copied.`
Thank you.
Cheers,
Marek
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
On 3/28/17 07:02, marek.cvoren@gmail.com wrote:
Please correct following part of pg_upgrade documentation:
`You can also specify user and port values, and whether you want the data
linked instead of copied (the default).`It is not clear what is the default option. If you read the whole sentence,
then context might be misinterpreted to `data linked instead of copied` is
default but you meant that copying is default. Please correct this as it is
confusing and can lead someone to big troubles.My suggestion:
- completely omit confusing default word:
`You can also specify user and port values, and whether you want the data
linked instead of copied.`
It's debatable whether that sentence is unclear, I think, but the change
you propose actually loses the information about what mode is the
default, which wouldn't be good.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
On Wed, Apr 5, 2017 at 12:28:46AM -0400, Peter Eisentraut wrote:
On 3/28/17 07:02, marek.cvoren@gmail.com wrote:
My suggestion:
- completely omit confusing default word:
`You can also specify user and port values, and whether you want the data
linked instead of copied.`It's debatable whether that sentence is unclear, I think, but the change
you propose actually loses the information about what mode is the
default, which wouldn't be good.
I have applied the attached doc patch to clarify this.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +