Behavior of recovery_target_inclusive.
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/10/static/index.html
Description:
Hi,
I found a small bug in the PostgreSQL 10 document.
https://www.postgresql.org/docs/10/static/recovery-target-settings.html
At "recovery_target_inclusive (boolean)", nothing is mentioned about
"recovery_target_lsn".
It should be fixed, since "recovery_target_lsn" is affected by the value of
"recovery_target_inclusive".
Could you check this?
Best regards,
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
On Mon, Oct 23, 2017 at 10:27 PM, <t.katsumata1122@gmail.com> wrote:
At "recovery_target_inclusive (boolean)", nothing is mentioned about
"recovery_target_lsn".
It should be fixed, since "recovery_target_lsn" is affected by the value of
"recovery_target_inclusive".Could you check this?
Apologies. You are right, this is a documentation bug and should be
fixed. Attached is a patch to address the problem. The trend on the
documentation page for recovery parameters is to list the options
alphabetically, so recovery_target_lsn comes first.
--
Michael
Attachments:
recovery-lsn-doc.patchapplication/octet-stream; name=recovery-lsn-doc.patchDownload+3-2
Hi Michael
Thanks for your reply and quick reaction.
2017-10-23 23:05 GMT+09:00 Michael Paquier <michael.paquier@gmail.com>:
On Mon, Oct 23, 2017 at 10:27 PM, <t.katsumata1122@gmail.com> wrote:
At "recovery_target_inclusive (boolean)", nothing is
mentioned about
"recovery_target_lsn".
It should be fixed, since "recovery_target_lsn" is affectedby the value of
"recovery_target_inclusive".
Could you check this?
Apologies. You are right, this is a documentation bug and should be
fixed. Attached is a patch to address the problem. The trend on the
documentation page for recovery parameters is to list the options
alphabetically, so recovery_target_lsn comes first.
--
Michael
Your patch seems good, but I have a question.
Does it need to fix the next sentence?
Like this:
----
This setting controls whether transactions having exactly the target WAL
location (LSN), commit time or ID, respectively, will be included in the
recovery.
----
Best regards,
On Tue, Oct 24, 2017 at 9:43 AM, Tomonari Katsumata
<t.katsumata1122@gmail.com> wrote:
Does it need to fix the next sentence?
Right.
--
Michael
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Hi,
I rivised the patch.
Please update the file with this patch.
Best regards,
2017-10-24 9:45 GMT+09:00 Michael Paquier <michael.paquier@gmail.com>:
Show quoted text
On Tue, Oct 24, 2017 at 9:43 AM, Tomonari Katsumata
<t.katsumata1122@gmail.com> wrote:Does it need to fix the next sentence?
Right.
--
Michael
Attachments:
recovery-lsn-doc2.patchapplication/octet-stream; name=recovery-lsn-doc2.patchDownload+4-3
On 10/23/17 23:59, Tomonari Katsumata wrote:
I rivised the patch.
Please update the file with this patch.
committed to master and PG 10
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs