PARALLEL in old syntax for CREATE AGGREGATE

Started by Daniel Gustafssonalmost 9 years ago3 messagesdocs
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

needs rebasesuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t76086
psql -h localhost -U postgres

Built from patchset v1 (message #1), August 23, 2026 at 08:17 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t76086_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t76086_1 && git checkout t76086_1

Patchset v1 (message #1) is on t76086_1

Jump to latest
#1Daniel Gustafsson
daniel@yesql.se

When looking at review comments on one of my patches, I noticed that commit
41ea0c23761 didn’t include the PARALLEL keyword for the old style CREATE
AGGREGATE syntax. Since it is supported, and commit 59b71c6fe6c use it in a
testcase, it seems reasonable to add something along the lines of the attached
patch to the docs.

cheers ./daniel

Attachments:

t76086_1
create_agg_parallel.patchapplication/octet-stream; name=create_agg_parallel.patchDownload+5-1
#2Bruce Momjian
bruce@momjian.us
In reply to: Daniel Gustafsson (#1)
Re: PARALLEL in old syntax for CREATE AGGREGATE

Robert, can you review the attached patch since it references your
commit? Thanks.

---------------------------------------------------------------------------

On Mon, Nov 27, 2017 at 04:00:42PM +0100, Daniel Gustafsson wrote:

When looking at review comments on one of my patches, I noticed that commit
41ea0c23761 didn’t include the PARALLEL keyword for the old style CREATE
AGGREGATE syntax. Since it is supported, and commit 59b71c6fe6c use it in a
testcase, it seems reasonable to add something along the lines of the attached
patch to the docs.

cheers ./daniel

From 2ed82ee3f3fa28bd69f2981730cf60d89c8f3867 Mon Sep 17 00:00:00 2001
From: Daniel Gustafsson <daniel@yesql.se>
Date: Mon, 27 Nov 2017 15:29:15 +0100
Subject: [PATCH 2/2] doc: add PARALLEL option to old syntax for CREATE
AGGREGATE

The old pre-8.2 syntax for CREATE AGGREGATE also support PARALLEL,
even though it's required to be quoted as PARALLEL is an unreserved
keyword.
---
doc/src/sgml/ref/create_aggregate.sgml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/doc/src/sgml/ref/create_aggregate.sgml b/doc/src/sgml/ref/create_aggregate.sgml
index a4aaae876e..d813ec41e6 100644
--- a/doc/src/sgml/ref/create_aggregate.sgml
+++ b/doc/src/sgml/ref/create_aggregate.sgml
@@ -80,6 +80,7 @@ CREATE AGGREGATE <replaceable class="parameter">name</replaceable> (
[ , MFINALFUNC_MODIFY = { READ_ONLY | SHARABLE | READ_WRITE } ]
[ , MINITCOND = <replaceable class="parameter">minitial_condition</replaceable> ]
[ , SORTOP = <replaceable class="parameter">sort_operator</replaceable> ]
+    [ , "PARALLEL" = { SAFE | RESTRICTED | UNSAFE } ]
)
</synopsis>
</refsynopsisdiv>
@@ -630,6 +631,10 @@ SELECT col FROM tab ORDER BY col USING sortop LIMIT 1;
functions are not consulted by the planner, only the marking of the
aggregate itself.
</para>
+     <para>
+       Note that when using the old syntax, <literal>"PARALLEL"</literal> must
+       be quoted.
+     </para>
</listitem>
</varlistentry>

--
2.14.1.145.gb3622a4ee

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +
#3Daniel Gustafsson
daniel@yesql.se
In reply to: Bruce Momjian (#2)
Re: PARALLEL in old syntax for CREATE AGGREGATE

On 24 Jan 2018, at 03:52, Bruce Momjian <bruce@momjian.us> wrote:

Robert, can you review the attached patch since it references your
commit? Thanks.

Another approach is the patch in 62991614-9673-4276-99CC-6754E7A0572F@yesql.se
which contains a fix which allows for PARALLEL to be unquoted in the old syntax.

cheers ./daniel