postgresql 11 release notes

same patch but renamed to match the patch file naming convention

On Thu, Jun 14, 2018 at 6:13 PM, Brad DeJong <bpd0018@gmail.com> wrote:

2018-06-15 7:58 GMT-03:00 Brad DeJong <bpd0018@gmail.com>:

same patch but renamed to match the patch file naming convention

Comments above:

        <para>
-        Previously super users were exclusively granted to access these
+        Previously, super-users were exclusively granted access to these
         functions.
        </para>

The terminology used in the documentation is "superuser".

        <para>
         The new unit is "B".  This is in addition to "kB", "MB", "GB"
-        and "TB", which were accepted previously.
+        and "TB", which are already allowed.
        </para>

I would replace only "were" by "are": "which are accepted previously".

        <para>
-        Exclude unlogged, temporary tables, and
+        Exclude unlogged, temporary tables and
         <filename>pg_internal.init</filename> files from streaming base
         backups (David Steele)
        </para>

AFAIK postgres uses Oxford comma a lot.

        <para>
         Also, if any table mentioned in <command>VACUUM</command> uses
-        a column list, then <command>ANALYZE</command> keyword must be
-        supplied;  previously <command>ANALYZE</command> was implied in
+        a column list, then the <command>ANALYZE</command> keyword must be
+        supplied. Previously, <command>ANALYZE</command> was implied in
         such cases.
        </para>

I prefer to maintain semicolon and add a comma after "previously".

        <para>
-        This allows <application>psql</application>'s default pager to
-        be specified as a separate environment variable from the pager
-        for other applications.  <envar>PAGER</envar> is still honored
-        if <envar>PSQL_PAGER</envar> is not set.
+        In addition to <application>psql</application>, other applications
+        use the <envar>PAGER</envar> environment variable. Having
+        <envar>PSQL_PAGER</envar> as a separate environment variable allows
+        you to use one pager for those applications and a different pager
+        for <application>psql</application>. <application>psql</application>
+        will still honor <envar>PAGER</envar> if <envar>PSQL_PAGER</envar>
+        is not set.
        </para>

I don't see this as an improvement.

        <para>
-        Add ability to suppress dumping and restoring of comments
+        Add an option to suppress dumping and restoring of comments
         (Robins Tharakan)
        </para>

I would suggest "Add an option to suppress dumping and restoring comments".

--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Brad, your forgot to reply to pgsql-docs.

2018-06-19 20:21 GMT-03:00 Brad DeJong <bpd0018@gmail.com>:

How about dropping the which clause entirely? I split this off as
release-11-newunit-v1.patch for further discussion.

Works for me. Could you append it to v2?

<para>
-        Exclude unlogged, temporary tables, and
+        Exclude unlogged, temporary tables and
<filename>pg_internal.init</filename> files from streaming base
backups (David Steele)
</para>

AFAIK postgres uses Oxford comma a lot.

I left this change in the v2 patch.
I didn't remove it because it was an Oxford comma; I removed it because
there are only two items, tables and files, so this should not be a comma
separated list.
Unlogged and temporary both modify tables and tell us what kind of tables
are being excluded.
If this was a list, the items should be semi-colon separated because of the
comma between unlogged and temporary.
For example - Exclude unlogged, temporary tables; b-tree indexes; and
pg_internal.init files from streaming base backups.

I see. I think the sentence should be "Exclude unlogged tables,
temporary tables, and <filename>pg_internal.init</filename> files from
streaming base backups".

--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

On Tue, Jun 19, 2018 at 9:20 PM, Euler Taveira <euler@timbira.com.br> wrote:

On Thu, Jun 21, 2018 at 5:08 AM, Brad DeJong <bpd0018@gmail.com> wrote:

On Tue, Jun 19, 2018 at 9:20 PM, Euler Taveira <euler@timbira.com.br>
wrote:

I see. I think the sentence should be "Exclude unlogged tables,
temporary tables, and <filename>pg_internal.init</filename> files from
streaming base backups".

I like it. Done.

Just to make the difference explicit

"Exclude unlogged, temporary tables and ..."
=> if (table.unlogged == true AND table.temporary == true) then exclude
table

"Exclude unlogged tables, temporary tables, and ..."
=> if (table.unlogged == true OR table.temporary == true) then exclude table

I do not know whether the condition is an AND or an OR.
When you said "I think the sentence should be ...", I took that to mean
that you know that the condition should be an OR.

2018-06-21 8:01 GMT-03:00 Brad DeJong <bpd0018@gmail.com>:

When you said "I think the sentence should be ...", I took that to mean that
you know that the condition should be an OR.

There are separate conditions in the code (each one was done in
separate commits).

--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

On Thu, Jun 21, 2018 at 05:08:39AM -0500, Brad DeJong wrote:

On Tue, Jun 19, 2018 at 9:20 PM, Euler Taveira <euler@timbira.com.br> wrote:

I left this change in the v2 patch.
I didn't remove it because it was an Oxford comma; I removed it because
there are only two items, tables and files, so this should not be a comma
separated list.
Unlogged and temporary both modify tables and tell us what kind of tables
are being excluded.
If this was a list, the items should be semi-colon separated because of

the

comma between unlogged and temporary.
For example - Exclude unlogged, temporary tables; b-tree indexes; and
pg_internal.init files from streaming base backups.

I see. I think the sentence should be "Exclude unlogged tables,
temporary tables, and <filename>pg_internal.init</filename> files from
streaming base backups".

I like it. Done.�

Patch applied. This was a great help, thanks. The "This features" typo
was already found. I did not apply this part since it would have added
whitespace after the period.

-        Add <link
-        linkend="pg-stat-activity-view"><structname>pg_stat_activity</structname>.<structfield>backend_type</structfield></link>
+        <link linkend="pg-stat-activity-view"><structname>pg_stat_activity</structname>.
+        <structfield>backend_type</structfield></link>

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +