uncommon syntax in datatype.sgml
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t76270psql -h localhost -U postgresBuilt from patchset v3 (message #3), July 28, 2026 at 01:51 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t76270_3 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t76270_3 && git checkout t76270_3Patchset v3 (message #3) is on t76270_3
Hi,
I have noticed uncommon English syntax in datatype.sgml, with two full
sentences following a colon in the same paragraph. I was inclined to
convert these sentences into a list, but this markup seems unpopular in
PostgreSQL docs for some reason. Please consider a less invasive patch
(attached) that fixes the issue.
--
Liudmila Mantrova
Technical writer at Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachments:
syntax-fix-in-datatype.patchtext/x-patch; name=syntax-fix-in-datatype.patchDownload+1-1
On 16.07.18 20:42, Liudmila Mantrova wrote:
I have noticed uncommon English syntax in datatype.sgml, with two full
sentences following a colon in the same paragraph.
I don't understand what's wrong with that.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 07/17/2018 01:52 PM, Peter Eisentraut wrote:
On 16.07.18 20:42, Liudmila Mantrova wrote:
I have noticed uncommon English syntax in datatype.sgml, with two full
sentences following a colon in the same paragraph.I don't understand what's wrong with that.
Hi Peter,
I have brought this up because the backpatch to REL9_6_STABLE and below
has lost the capital letter after the colon (commit 037768cf), so I
think this phrase is likely to confuse others in a similar way.
The current syntax in master is indeed acceptable, e.g. Chicago Manual
of Style says:
"The colon may sometimes be used instead of a period to introduce a
series of related sentences." However, this wording suggests to me that
it's not the most common usage, so it can confuse non-native speakers
(like me).
Alternatively, we could fix the backpatch only. The patch based on
REL9_6_STABLE is attached if you decide to choose this path.
--
Liudmila Mantrova
Technical writer at Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company