Minor correction in the doc for non-exclusive pg_start_backup and pg_stop_backup

Started by Fujii Masaoalmost 7 years ago3 messagesdocs
Jump to latest
#1Fujii Masao
masao.fujii@gmail.com

Hi,

These functions cannot be executed during recovery (except
<function>pg_is_in_backup</function>, <function>pg_backup_start_time</function>
and <function>pg_wal_lsn_diff</function>).

Regarding backup control functions, the func.sgml describes as above.
But non-exclusive pg_start_backup and pg_stop_backup can also be
executed during recovery, and which should be described in the doc.
So I think that the attached patch should be pushed. Thought?

Probably the patch needs to be back-patched to 9.6 where non-exclusive
backup API was added.

Regards,

--
Fujii Masao

Attachments:

backup-doc.patchapplication/octet-stream; name=backup-doc.patchDownload+2-0
#2Michael Paquier
michael@paquier.xyz
In reply to: Fujii Masao (#1)
Re: Minor correction in the doc for non-exclusive pg_start_backup and pg_stop_backup

On Fri, Apr 19, 2019 at 12:38:23AM +0900, Fujii Masao wrote:

Regarding backup control functions, the func.sgml describes as above.
But non-exclusive pg_start_backup and pg_stop_backup can also be
executed during recovery, and which should be described in the doc.
So I think that the attached patch should be pushed. Thought?

Probably the patch needs to be back-patched to 9.6 where non-exclusive
backup API was added.

+1.
--
Michael
#3Fujii Masao
masao.fujii@gmail.com
In reply to: Michael Paquier (#2)
Re: Minor correction in the doc for non-exclusive pg_start_backup and pg_stop_backup

On Fri, Apr 19, 2019 at 11:36 AM Michael Paquier <michael@paquier.xyz> wrote:

On Fri, Apr 19, 2019 at 12:38:23AM +0900, Fujii Masao wrote:

Regarding backup control functions, the func.sgml describes as above.
But non-exclusive pg_start_backup and pg_stop_backup can also be
executed during recovery, and which should be described in the doc.
So I think that the attached patch should be pushed. Thought?

Probably the patch needs to be back-patched to 9.6 where non-exclusive
backup API was added.

+1.

Thanks! Committed.

Regards,

--
Fujii Masao