Improvement of GIN figure
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t76502psql -h localhost -U postgresBuilt from patchset v6 (message #6), July 28, 2026 at 04:03 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t76502_6 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t76502_6 && git checkout t76502_6Patchset v6 (message #6) is on t76502_6
To increase the consistency between the surrounding, explaining text and
the figure, there are some changes and additions to the texts within the
figure.
Also: Added a hint in README for ditaa developers.
Jürgen Purtz
On Sun, Jul 7, 2019 at 4:18 PM Jürgen Purtz <juergen@purtz.de> wrote:
To increase the consistency between the surrounding, explaining text and
the figure, there are some changes and additions to the texts within the
figure.
Sorry, I may missed the discussion of what colors and fonts we accept
for our documentation, but
the color and fonts used I don't like. I attached our version of GIN figure.
Also: Added a hint in README for ditaa developers.
Jürgen Purtz
--
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachments:
gin.jpgimage/jpeg; name=gin.jpgDownload+5-9
On Tue, Jul 9, 2019 at 12:20 AM Oleg Bartunov <obartunov@postgrespro.ru> wrote:
Sorry, I may missed the discussion of what colors and fonts we accept
for our documentation, but
the color and fonts used I don't like. I attached our version of GIN figure.
I agree that the existing colors look awful, and that muted pastel
colors would work better. Doesn't seem like something that should
happen at the cost of making the diagram less informative, though.
--
Peter Geoghegan
I agree that the existing colors look awful, and that muted pastel
colors would work better. Doesn't seem like something that should
happen at the cost of making the diagram less informative, though.
I am not an expert in the area but I think we should cosider people
with color disability.
https://www.invisionapp.com/inside-design/color-accessibility-product-design/
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
On Tue, Jul 9, 2019 at 3:22 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
I agree that the existing colors look awful, and that muted pastel
colors would work better. Doesn't seem like something that should
happen at the cost of making the diagram less informative, though.I am not an expert in the area but I think we should cosider people
with color disability.
Good point. I think that that shouldn't be too hard to mostly get right.
It's good that the diagrams will already work with a screen reader.
--
Peter Geoghegan
On Tue, Jul 9, 2019 at 3:22 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
I agree that the existing colors look awful, and that muted pastel
colors would work better. Doesn't seem like something that should
happen at the cost of making the diagram less informative, though.I am not an expert in the area but I think we should cosider people
with color disability.Good point. I think that that shouldn't be too hard to mostly get right.
It's good that the diagrams will already work with a screen reader.
Due to the discussions of recent days as well as some improvements of
the graphiz know-how, the graphic is subject to many changes: different
colors (variations of 'PG blue', and possibly helpful for people with
color vision deficiency), a different font (adaption to the font in PG's
documentation), changes in the meaning and explanation of nodes (as a
result of discussion with Oleg Bartunov), introduction of a - hopefully
unobtrusive - background color (to circumvent graphic from text), use of
DOT syntax.