Possible typos in the #12.1.1 examples

Started by PG Bug reporting formabout 6 years ago3 messagesdocs
Jump to latest
#1PG Bug reporting form
noreply@postgresql.org

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/12/textsearch-intro.html
Description:

SELECT title || ' ' || author || ' ' || abstract || ' ' || body AS
document
FROM messages
WHERE mid = 12;

Seems like here the example missed 'm' as an alias and a dot in the `where`
clause:
... messages m
... m.id = 12;

SELECT m.title || ' ' || m.author || ' ' || m.abstract || ' ' || d.body AS
document
FROM messages m, docs d
WHERE mid = did AND mid = 12;

Possibly, the example missed dots:
... m.id = d.id AND m.id = 12;

Thanks!

#2Michael Paquier
michael@paquier.xyz
In reply to: PG Bug reporting form (#1)
Re: Possible typos in the #12.1.1 examples

On Mon, Mar 02, 2020 at 03:38:01PM +0000, PG Doc comments form wrote:

Seems like here the example missed 'm' as an alias and a dot in the `where`
clause:
... messages m
... m.id = 12;

This query is valid as-is.

SELECT m.title || ' ' || m.author || ' ' || m.abstract || ' ' || d.body AS
document
FROM messages m, docs d
WHERE mid = did AND mid = 12;

Possibly, the example missed dots:
... m.id = d.id AND m.id = 12;

This one is actually valid as well, as long as both relations don't
use the same column names, but I can see your point to add the aliases
to the quals of the WHERE clause to bring more clarity.
--
Michael

#3Bruce Momjian
bruce@momjian.us
In reply to: Michael Paquier (#2)
Re: Possible typos in the #12.1.1 examples

On Thu, Mar 5, 2020 at 04:45:23PM +0900, Michael Paquier wrote:

On Mon, Mar 02, 2020 at 03:38:01PM +0000, PG Doc comments form wrote:

Seems like here the example missed 'm' as an alias and a dot in the `where`
clause:
... messages m
... m.id = 12;

This query is valid as-is.

SELECT m.title || ' ' || m.author || ' ' || m.abstract || ' ' || d.body AS
document
FROM messages m, docs d
WHERE mid = did AND mid = 12;

Possibly, the example missed dots:
... m.id = d.id AND m.id = 12;

This one is actually valid as well, as long as both relations don't
use the same column names, but I can see your point to add the aliases
to the quals of the WHERE clause to bring more clarity.

Agreed, alias added in all supported branches.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +