The order of columns about WAL activity in pg_stat_statements

Started by Fujii Masaoover 6 years ago3 messagesdocs
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t76752
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 28, 2026 at 02:40 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t76752_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t76752_1 && git checkout t76752_1

Patchset v1 (message #1) is on t76752_1

Jump to latest
#1Fujii Masao
masao.fujii@gmail.com

Hi,

https://www.postgresql.org/docs/devel/pgstatstatements.html

In pg_stat_statements docs, the columns about WAL activity are put
in the table in the order of wal_bytes, wal_records and wal_fpi. But
in the definition of pg_stat_statements view, wal_bytes is put last.
So I think that it's better to reorder those columns in a consistent
with the view definition. Patch attached. Thought?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachments:

t76752_1
pgss_docs.patchtext/plain; charset=UTF-8; name=pgss_docs.patch; x-mac-creator=0; x-mac-type=0Download+9-9
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Fujii Masao (#1)
Re: The order of columns about WAL activity in pg_stat_statements

Fujii Masao <masao.fujii@oss.nttdata.com> writes:

In pg_stat_statements docs, the columns about WAL activity are put
in the table in the order of wal_bytes, wal_records and wal_fpi. But
in the definition of pg_stat_statements view, wal_bytes is put last.
So I think that it's better to reorder those columns in a consistent
with the view definition. Patch attached. Thought?

I already fixed this in my pending patch to restructure the catalog
docs [1]/messages/by-id/14810.1589128043@sss.pgh.pa.us.

regards, tom lane

[1]: /messages/by-id/14810.1589128043@sss.pgh.pa.us

#3Fujii Masao
masao.fujii@gmail.com
In reply to: Tom Lane (#2)
Re: The order of columns about WAL activity in pg_stat_statements

On 2020/05/14 0:41, Tom Lane wrote:

Fujii Masao <masao.fujii@oss.nttdata.com> writes:

In pg_stat_statements docs, the columns about WAL activity are put
in the table in the order of wal_bytes, wal_records and wal_fpi. But
in the definition of pg_stat_statements view, wal_bytes is put last.
So I think that it's better to reorder those columns in a consistent
with the view definition. Patch attached. Thought?

I already fixed this in my pending patch to restructure the catalog
docs [1].

Sounds nice. Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION