strange syntax

Started by PG Bug reporting formover 5 years ago4 messagesdocs
Jump to latest
#1PG Bug reporting form
noreply@postgresql.org

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/12/manage-ag-overview.html
Description:

this sentence looks strange:
"Schemas are a purely logical structure and who can access what is managed
by the privilege system"
https://www.postgresql.org/docs/12/manage-ag-overview.html

especially this part: "who can access what is managed by"

#2Laurenz Albe
laurenz.albe@cybertec.at
In reply to: PG Bug reporting form (#1)
Re: strange syntax

On Tue, 2020-07-14 at 21:33 +0000, PG Doc comments form wrote:

this sentence looks strange:
"Schemas are a purely logical structure and who can access what is managed
by the privilege system"
https://www.postgresql.org/docs/12/manage-ag-overview.html

especially this part: "who can access what is managed by"

It is correct English, but maybe it could be worded better:

"Schemas are a purely logical structure and impose no access restrictions,
apart from those defined by the privilege system."

Yours,
Laurenz Albe

#3David G. Johnston
david.g.johnston@gmail.com
In reply to: Laurenz Albe (#2)
Re: strange syntax

On Thu, Jul 16, 2020 at 11:58 AM Laurenz Albe <laurenz.albe@cybertec.at>
wrote:

On Tue, 2020-07-14 at 21:33 +0000, PG Doc comments form wrote:

this sentence looks strange:
"Schemas are a purely logical structure and who can access what is

managed

by the privilege system"
https://www.postgresql.org/docs/12/manage-ag-overview.html

especially this part: "who can access what is managed by"

It is correct English, but maybe it could be worded better:

Agreed

"Schemas are a purely logical structure and impose no access restrictions,
apart from those defined by the privilege system."

But I don't think this is an improvement.

I think "modular" is a better term than "logical" here.

Given that we've already said "multiple databases, which are isolated from
each other" trying to say the same thing with "impose no access
restrictions" doesn't seem to help; and one of the two major benefits of
schemas is to provide privilege system hook less granular than object -
which the original puts forward directly but clumsily and the proposal sets
into an aside ("apart from"). The other benefit, namespace isolation,
isn't even mentioned but seems like a useful addition.

Thus:

Schemas provide modular structure, with namespace isolation and
authorization control.
or
... possibly into separate schemas; which provide modular structure with
namespace isolation and authorization control.
David J.

#4David G. Johnston
david.g.johnston@gmail.com
In reply to: David G. Johnston (#3)
Re: strange syntax

On Thu, Jul 16, 2020 at 1:38 PM David G. Johnston <
david.g.johnston@gmail.com> wrote:

On Thu, Jul 16, 2020 at 11:58 AM Laurenz Albe <laurenz.albe@cybertec.at>
wrote:

On Tue, 2020-07-14 at 21:33 +0000, PG Doc comments form wrote:

this sentence looks strange:
"Schemas are a purely logical structure and who can access what is

managed

by the privilege system"
https://www.postgresql.org/docs/12/manage-ag-overview.html

especially this part: "who can access what is managed by"

It is correct English, but maybe it could be worded better:

Agreed

"Schemas are a purely logical structure and impose no access restrictions,
apart from those defined by the privilege system."

But I don't think this is an improvement.

I went ahead and reviewed the whole page and came up with a minor rework
patch instead of just a targeted fix.

/messages/by-id/CAKFQuwacZW-gNLyScFKFxCg_g7QtT7_HQMOyexuV2zUj=eQFAw@mail.gmail.com

David J.