Update limitations for declarative partitioning

Started by Erwin Brandstetterover 5 years ago5 messagesdocs
Jump to latest
#1Erwin Brandstetter
brsaweda@gmail.com

The release notes for pg 13 advertise a new feature in
https://www.postgresql.org/docs/13/release-13.html#DDL-PARTITION-PRUNING

-

Allow BEFORE row-level triggers
<https://www.postgresql.org/docs/13/triggers.html&gt; on partitioned tables
(Álvaro Herrera)

These triggers cannot change which partition is the destination.

- But the manual still warns at
https://www.postgresql.org/docs/13/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-LIMITATIONS

BEFORE ROW triggers, if necessary, must be defined on individual

partitions, not the partitioned table.

Looks like that "limitation" can go now? Or reduced to something like:

"BEFORE ROW triggers on the partitioned table cannot change which partition
is the destination."

Regards
Erwin

#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Erwin Brandstetter (#1)
Re: Update limitations for declarative partitioning

On 2020-Aug-08, Erwin Brandstetter wrote:

- But the manual still warns at
https://www.postgresql.org/docs/13/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-LIMITATIONS

BEFORE ROW triggers, if necessary, must be defined on individual

partitions, not the partitioned table.

Looks like that "limitation" can go now? Or reduced to something like:

"BEFORE ROW triggers on the partitioned table cannot change which partition
is the destination."

Oh, right, I'll patch that up tomorrow. Thanks for pointing it out.

--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

#3Erwin Brandstetter
brsaweda@gmail.com
In reply to: Alvaro Herrera (#2)
Re: Update limitations for declarative partitioning

Looking at
https://www.postgresql.org/docs/devel/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-LIMITATIONS
... the issue seems unchanged?

Regards
Erwin

On Sat, 8 Aug 2020 at 05:38, Alvaro Herrera <alvherre@2ndquadrant.com>
wrote:

Show quoted text

On 2020-Aug-08, Erwin Brandstetter wrote:

- But the manual still warns at

https://www.postgresql.org/docs/13/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-LIMITATIONS

BEFORE ROW triggers, if necessary, must be defined on individual

partitions, not the partitioned table.

Looks like that "limitation" can go now? Or reduced to something like:

"BEFORE ROW triggers on the partitioned table cannot change which

partition

is the destination."

Oh, right, I'll patch that up tomorrow. Thanks for pointing it out.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

#4Michael Paquier
michael@paquier.xyz
In reply to: Erwin Brandstetter (#3)
Re: Update limitations for declarative partitioning

On Sun, Aug 30, 2020 at 11:39:59PM +0200, Erwin Brandstetter wrote:

Looking at
https://www.postgresql.org/docs/devel/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-LIMITATIONS
... the issue seems unchanged?

Indeed, there is no fix in the code tree. Alvaro? If there is no
update, I'll go fix that myself.
--
Michael

#5Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#4)
Re: Update limitations for declarative partitioning

On Mon, Aug 31, 2020 at 11:18:55AM +0900, Michael Paquier wrote:

Indeed, there is no fix in the code tree. Alvaro? If there is no
update, I'll go fix that myself.

For the archives: this has been done with 97dc0d1.

(Thanks, Alvaro!)
--
Michael