Fix the example in the document of file-fdw
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t76843psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 27, 2026 at 06:38 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t76843_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t76843_1 && git checkout t76843_1Patchset v1 (message #1) is on t76843_1
Although csvlog has the leader_pid field, the document of file-fdw
that uses csvlog as an example does not reflect this fact.
Concretely, the DDL for table definition does not have the leader_pid
field.
This patch fixes the DDL in the document of file-fdw.
Regards,
Yuta Katsuragi
On 2020/09/14 11:19, btkatsuragiyu wrote:
Although csvlog has the leader_pid field, the document of file-fdw
that uses csvlog as an example does not reflect this fact.
Concretely, the DDL for table definition does not have the leader_pid field.
This seems an oversight of commit b8fdee7d0c.
This patch fixes the DDL in the document of file-fdw.
Thanks for the patch! LGTM. I will commit it.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On Mon, Sep 14, 2020 at 11:33:23AM +0900, Fujii Masao wrote:
On 2020/09/14 11:19, btkatsuragiyu wrote:
Although csvlog has the leader_pid field, the document of file-fdw
that uses csvlog as an example does not reflect this fact.
Concretely, the DDL for table definition does not have the leader_pid field.This seems an oversight of commit b8fdee7d0c.
Dammit, I thought that I had all the places for that stuff done. The
patch looks fine to me.
This patch fixes the DDL in the document of file-fdw.
Thanks for the patch! LGTM. I will commit it.
Hmm. Instead of keeping a copy-paste of the same table in both
config.sgml and file-fdw.sgml, why not having only one? It seems to
me that we could just have the file_fdw doc refer to the main
configuration, and it is not difficult to guess how the CREATE TABLE
query needs to be changed to map with foreign table.
--
Michael
On 2020-09-14 14:07, Michael Paquier wrote:
On Mon, Sep 14, 2020 at 11:33:23AM +0900, Fujii Masao wrote:
On 2020/09/14 11:19, btkatsuragiyu wrote:
This patch fixes the DDL in the document of file-fdw.
Thanks for the patch! LGTM. I will commit it.
Hmm. Instead of keeping a copy-paste of the same table in both
config.sgml and file-fdw.sgml, why not having only one?
I agree with this comment.
It seems to me that we could just have the file_fdw doc refer to the
main
configuration, and it is not difficult to guess how the CREATE TABLE
query needs to be changed to map with foreign table.
However, I think showing complete DDL including SERVER pglog and OPTIONS
would be helpful
to users who are not familiar with this feature.
Regards,
Yuta Katsuragi
On Mon, Sep 14, 2020 at 04:10:03PM +0900, btkatsuragiyu wrote:
However, I think showing complete DDL including SERVER pglog and OPTIONS
would be helpful
to users who are not familiar with this feature.
Yeah, this could be mentioned on the doc page for file_fdw with an
extra sentence, but I agree that it is more complex to understand that
than a simple copy-paste from the doc itself.
--
Michael
On 2020/09/14 16:56, Michael Paquier wrote:
On Mon, Sep 14, 2020 at 04:10:03PM +0900, btkatsuragiyu wrote:
However, I think showing complete DDL including SERVER pglog and OPTIONS
would be helpful
to users who are not familiar with this feature.
Agreed.
Yeah, this could be mentioned on the doc page for file_fdw with an
extra sentence, but I agree that it is more complex to understand that
than a simple copy-paste from the doc itself.
So ISTM our consensus is to apply the proposed patch.
Barring any objection, I will do that.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On Tue, Sep 15, 2020 at 04:43:39PM +0900, Fujii Masao wrote:
So ISTM our consensus is to apply the proposed patch.
Barring any objection, I will do that.
No objections from here at the end.
--
Michael
On 2020/09/15 16:59, Michael Paquier wrote:
On Tue, Sep 15, 2020 at 04:43:39PM +0900, Fujii Masao wrote:
So ISTM our consensus is to apply the proposed patch.
Barring any objection, I will do that.No objections from here at the end.
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION