Functions should be Functions & Procedures

On Tue, Nov 24, 2020 at 07:15:29PM +0000, PG Doc comments form wrote:

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/plpgsql-overview.html
Description:

Hi,

since PostgreSQL 11 we have procedures, so referencing to only functions
here seems to ignore that. Shouldn't procedures be mentioned here as well?

Good point. It seems PL/pgSQL, PL/Perl, PL/Python, PL/Tcl, and SPI
server-side languages all support procedures. I have developed the
attached patch to mention procedures right at the top. I didn't see a
need to mention function "or procedure" throughout the entire document.
Does this seem sufficient?

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

Hi Bruce,

On Tue, Nov 24, 2020 at 07:15:29PM +0000, PG Doc comments form wrote:

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/plpgsql-overview.html
Description:

Hi,

since PostgreSQL 11 we have procedures, so referencing to only functions
here seems to ignore that. Shouldn't procedures be mentioned here as well?

Good point.  It seems PL/pgSQL, PL/Perl, PL/Python, PL/Tcl, and SPI
server-side languages all support procedures.  I have developed the
attached patch to mention procedures right at the top.  I didn't see a
need to mention function "or procedure" throughout the entire document.
Does this seem sufficient?

Thanks for looking at it. Seems you attachment is corrupt, at least I can not open it. Can you please resend?

Regards
Daniel

On Wed, Nov 25, 2020 at 06:23:44PM +0000, Daniel Westermann (DWE) wrote:

Hi Bruce,

On Tue, Nov 24, 2020 at 07:15:29PM +0000, PG Doc comments form wrote:

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/plpgsql-overview.html
Description:

Hi,

since PostgreSQL 11 we have procedures, so referencing to only functions
here seems to ignore that. Shouldn't procedures be mentioned here as well?

Good point.� It seems PL/pgSQL, PL/Perl, PL/Python, PL/Tcl, and SPI
server-side languages all support procedures.� I have developed the
attached patch to mention procedures right at the top.� I didn't see a
need to mention function "or procedure" throughout the entire document.
Does this seem sufficient?

Thanks for looking at it. Seems you attachment is corrupt, at least I can not open it. Can you please resend?

It is a gzipp'ed file. I had to use gzip and can't resend it since it
contains the T-C-L URL that is flagged by Spamhaus as spam and causes my
emails to be marked as spam. You can see the patch here:

https://momjian.us/tmp/proc.txt

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

On Wed, Nov 25, 2020 at 06:23:44PM +0000, Daniel Westermann (DWE) wrote:

Hi Bruce,

On Tue, Nov 24, 2020 at 07:15:29PM +0000, PG Doc comments form wrote:

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/plpgsql-overview.html
Description:

Hi,

since PostgreSQL 11 we have procedures, so referencing to only functions
here seems to ignore that. Shouldn't procedures be mentioned here as well?

Good point.  It seems PL/pgSQL, PL/Perl, PL/Python, PL/Tcl, and SPI
server-side languages all support procedures.  I have developed the
attached patch to mention procedures right at the top.  I didn't see a
need to mention function "or procedure" throughout the entire document.
Does this seem sufficient?

Thanks for looking at it. Seems you attachment is corrupt, at least I can not open it. Can you please resend?

It is a gzipp'ed file.  I had to use gzip and can't resend it since it
contains the T-C-L URL that is flagged by Spamhaus as spam and causes my
emails to be marked as spam. You can see the patch here:

Looks good, thanks.

Regards
Daniel

On Wed, Nov 25, 2020 at 06:38:56PM +0000, Daniel Westermann (DWE) wrote:

On Wed, Nov 25, 2020 at 06:23:44PM +0000, Daniel Westermann (DWE) wrote:

Good point.� It seems PL/pgSQL, PL/Perl, PL/Python, PL/Tcl, and SPI
server-side languages all support procedures.� I have developed the
attached patch to mention procedures right at the top.� I didn't see a
need to mention function "or procedure" throughout the entire document.
Does this seem sufficient?

Thanks for looking at it. Seems you attachment is corrupt, at least I can not open it. Can you please resend?

It is a gzipp'ed file.� I had to use gzip and can't resend it since it
contains the T-C-L URL that is flagged by Spamhaus as spam and causes my
emails to be marked as spam. You can see the patch here:

Looks good, thanks.

Thanks, patch applied through 11.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee