[DOC] pg_stat_replication_slots representation style inconsisitant
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t76984psql -h localhost -U postgresBuilt from patchset v3 (message #3), July 27, 2026 at 05:07 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t76984_3 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t76984_3 && git checkout t76984_3Patchset v3 (message #3) is on t76984_3
Hi
When reading the manual doc, I found an inconsistent representation style for the newly added pg_stat_prefetch_recovery view in PG14 at [1]https://www.postgresql.org/docs/devel/monitoring-stats.html#MONITORING-PG-STAT-SUBSCRIPTION.
Same problem seems to be reported by Noriyoshi Shinoda who also proposed a patch to fix the problem at[2]/messages/by-id/TU4PR8401MB1152945E4FD45E99C3F52B94EE4F9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM.
I tried to fix the problem in a way different than Noriyoshi Shinoda which I think is more consistent with the existing specific view introduction in the same page.
Please take the attached patch as your reference.
[1]: https://www.postgresql.org/docs/devel/monitoring-stats.html#MONITORING-PG-STAT-SUBSCRIPTION
https://www.postgresql.org/docs/devel/monitoring-stats.html#MONITORING-PG-STAT-SUBSCRIPTION
[2]: /messages/by-id/TU4PR8401MB1152945E4FD45E99C3F52B94EE4F9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM
/messages/by-id/TU4PR8401MB1152945E4FD45E99C3F52B94EE4F9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM
Regards,
Tang
Attachments:
0001-pg_stat_prefetch_recovery_doc.patchapplication/octet-stream; name=0001-pg_stat_prefetch_recovery_doc.patchDownload+116-69
When reading the manual doc, I found an inconsistent representation style for
the newly added pg_stat_prefetch_recovery view in PG14 at [1].
Same problem seems to be reported by Noriyoshi Shinoda who also proposed
a patch to fix the problem at[2].
I tried to fix the problem in a way different than Noriyoshi Shinoda which I think
is more consistent with the existing specific view introduction in the same
page.
Please take the attached patch as your reference.
I noticed one more thing.
It seems the column " stats_reset | timestamp with time zone " is not listed in the pg_stat_prefetch_recovery view.
Should we add this column too ?
Best regards,
houzj
On Friday, April 30, 2021 12:38 PM, Hou, Zhijie/侯 志杰 <houzj.fnst@fujitsu.com> wrote
I noticed one more thing.
It seems the column " stats_reset | timestamp with time zone " is not listed in the pg_stat_prefetch_recovery view.
Should we add this column too ?
Indeed, column added. Thanks.
Regards,
Tang
On Fri, Apr 30, 2021 at 03:48:27AM +0000, tanghy.fnst@fujitsu.com wrote:
Indeed, column added. Thanks.
I was looking at this thread, and please note that there is no need to
do anything here as the WAL prefetch has been reverted for now as of
c2dc1934.
--
Michael
On Tuesday, May 11, 2021 2:42 PM, Michael Paquier <michael@paquier.xyz> wrote:
I was looking at this thread, and please note that there is no need to
do anything here as the WAL prefetch has been reverted for now as of
c2dc1934.
Thanks for the updating. Got it.
Regards,
Tang
On Wed, May 12, 2021 at 12:49 AM tanghy.fnst@fujitsu.com
<tanghy.fnst@fujitsu.com> wrote:
On Tuesday, May 11, 2021 2:42 PM, Michael Paquier <michael@paquier.xyz> wrote:
I was looking at this thread, and please note that there is no need to
do anything here as the WAL prefetch has been reverted for now as of
c2dc1934.Thanks for the updating. Got it.
Thanks for the feedback. I'll be re-proposing the feature for 15 and
I've made a note about this thread.