Cities name column name inconsistent

Started by PG Bug reporting formalmost 5 years ago5 messagesdocs
Jump to latest
#1PG Bug reporting form
noreply@postgresql.org

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/tutorial-fk.html
Description:

In earlier sections of the tutorial, the cities table had a column called
'name'. In this chapter, when creating the revised schema with foreign keys,
the same column in the cities is now called 'city'.

#2David G. Johnston
david.g.johnston@gmail.com
In reply to: PG Bug reporting form (#1)
Re: Cities name column name inconsistent

On Sat, Jun 12, 2021, 12:28 PG Doc comments form <noreply@postgresql.org>
wrote:

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/tutorial-fk.html
Description:

In earlier sections of the tutorial, the cities table had a column called
'name'. In this chapter, when creating the revised schema with foreign
keys,
the same column in the cities is now called 'city'.

You are correct. I don't see an urgent need to spend time figuring out
something different.

David J.

#3Bruce Momjian
bruce@momjian.us
In reply to: David G. Johnston (#2)
Re: Cities name column name inconsistent

On Sat, Jun 12, 2021 at 12:48:25PM -0700, David G. Johnston wrote:

On Sat, Jun 12, 2021, 12:28 PG Doc comments form <noreply@postgresql.org>
wrote:

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/tutorial-fk.html
Description:

In earlier sections of the tutorial, the cities table had a column called
'name'. In this chapter, when creating the revised schema with foreign
keys,
the same column in the cities is now called 'city'.

You are correct.� I don't see an urgent need to spend time figuring out
something different.

I wrote the attached patch to improve this case.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

If only the physical world exists, free will is an illusion.

Attachments:

cities.difftext/x-diff; charset=us-asciiDownload+3-3
#4Peter Eisentraut
peter_e@gmx.net
In reply to: Bruce Momjian (#3)
Re: Cities name column name inconsistent

On 14.06.21 18:29, Bruce Momjian wrote:

On Sat, Jun 12, 2021 at 12:48:25PM -0700, David G. Johnston wrote:

On Sat, Jun 12, 2021, 12:28 PG Doc comments form <noreply@postgresql.org>
wrote:

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/tutorial-fk.html
Description:

In earlier sections of the tutorial, the cities table had a column called
'name'. In this chapter, when creating the revised schema with foreign
keys,
the same column in the cities is now called 'city'.

You are correct.� I don't see an urgent need to spend time figuring out
something different.

I wrote the attached patch to improve this case.

The tutorial documentation is meant to be consistent with src/tutorial/,
which uses cities.name, so calling the column "city" was just plain
wrong in that respect.

#5Bruce Momjian
bruce@momjian.us
In reply to: Peter Eisentraut (#4)
Re: Cities name column name inconsistent

On Thu, Jun 24, 2021 at 01:24:01PM +0200, Peter Eisentraut wrote:

On 14.06.21 18:29, Bruce Momjian wrote:

On Sat, Jun 12, 2021 at 12:48:25PM -0700, David G. Johnston wrote:

On Sat, Jun 12, 2021, 12:28 PG Doc comments form <noreply@postgresql.org>
You are correct.  I don't see an urgent need to spend time figuring out
something different.

I wrote the attached patch to improve this case.

The tutorial documentation is meant to be consistent with src/tutorial/,
which uses cities.name, so calling the column "city" was just plain wrong in
that respect.

Patch applied back to 9.6.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

If only the physical world exists, free will is an illusion.