change float4 to floating point about type of autovacuum_vacuum_insert_scale_factor

Started by Shinya11.Kato@nttdata.comalmost 5 years ago2 messagesdocs
Jump to latest
#1Shinya11.Kato@nttdata.com
Shinya11.Kato@nttdata.com

Hi

As shown below, the argument types of autovacuum_vacuum_insert_scale_factor and toast.autovacuum_vacuum_insert_scale_factor are different from the others.
---
autovacuum_vacuum_scale_factor, toast.autovacuum_vacuum_scale_factor (floating point)
autovacuum_vacuum_insert_scale_factor, toast.autovacuum_vacuum_insert_scale_factor (float4)
autovacuum_analyze_scale_factor (floating point)
autovacuum_vacuum_cost_delay, toast.autovacuum_vacuum_cost_delay (floating point)
https://www.postgresql.org/docs/devel/sql-createtable.html
---

In addition, there is this statement.
---
autovacuum_vacuum_insert_scale_factor (floating point)
https://www.postgresql.org/docs/devel/runtime-config-autovacuum.html#GUC-AUTOVACUUM-VACUUM-INSERT-SCALE-FACTOR
---

So, I thought it was better to be consistent with "floating point", and I created the patch.

A similar argument can be found here.
/messages/by-id/CACZ0uYFf_p9BpbjLccx3CA=eM1Hk2Te=ULY4iptGLUhL-JxCPA@mail.gmail.com

Best Regards,
Shinya Kato

Attachments:

change_float4_to_floating_point.patchapplication/octet-stream; name=change_float4_to_floating_point.patchDownload+1-1
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Shinya11.Kato@nttdata.com (#1)
Re: change float4 to floating point about type of autovacuum_vacuum_insert_scale_factor

On 16.06.21 07:22, Shinya11.Kato@nttdata.com wrote:

As shown below, the argument types of autovacuum_vacuum_insert_scale_factor and toast.autovacuum_vacuum_insert_scale_factor are different from the others.
---
autovacuum_vacuum_scale_factor, toast.autovacuum_vacuum_scale_factor (floating point)
autovacuum_vacuum_insert_scale_factor, toast.autovacuum_vacuum_insert_scale_factor (float4)
autovacuum_analyze_scale_factor (floating point)
autovacuum_vacuum_cost_delay, toast.autovacuum_vacuum_cost_delay (floating point)
https://www.postgresql.org/docs/devel/sql-createtable.html
---

So, I thought it was better to be consistent with "floating point", and I created the patch.

committed