COMMENT ON lock

Started by nikolai.berkoffabout 4 years ago4 messagesdocs
Jump to latest
#1nikolai.berkoff
nikolai.berkoff@pm.me

I wanted to know what lock the COMMENT ON command took and I had to look in the source code, makes sense to me that it should be documented. I've also added it to the list of commands that take a SHARE UPDATE EXCLUSIVE lock.

Regards,

Nikolai

Attachments:

comment_on_lock.patchtext/x-patch; filename=comment_on_lock.patch; name=comment_on_lock.patchDownload+2-1
#2Laurenz Albe
laurenz.albe@cybertec.at
In reply to: nikolai.berkoff (#1)
Re: COMMENT ON lock

On Tue, 2022-01-18 at 14:11 +0000, nikolai.berkoff wrote:

I wanted to know what lock the COMMENT ON command took and I had to look in the
source code, makes sense to me that it should be documented.  I've also added
it to the list of commands that take a SHARE UPDATE EXCLUSIVE lock.

+1, but SHARE ACCESS EXCLUSIVE should be marked up with <literal>.

Yours,
Laurenz Albe

#3Michael Paquier
michael@paquier.xyz
In reply to: Laurenz Albe (#2)
Re: COMMENT ON lock

On Tue, Jan 18, 2022 at 03:37:35PM +0100, Laurenz Albe wrote:

On Tue, 2022-01-18 at 14:11 +0000, nikolai.berkoff wrote:

I wanted to know what lock the COMMENT ON command took and I had to look in the
source code, makes sense to me that it should be documented.  I've also added
it to the list of commands that take a SHARE UPDATE EXCLUSIVE lock.

+1.

No objections to add more details for all that. Will fix.
--
Michael

#4Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#3)
Re: COMMENT ON lock

On Wed, Jan 19, 2022 at 01:45:07PM +0900, Michael Paquier wrote:

No objections to add more details for all that. Will fix.

And done as of b2a76bb.
--
Michael