"Restore" vs. "Reload"

Started by PG Bug reporting formabout 4 years ago4 messagesdocs
Jump to latest
#1PG Bug reporting form
noreply@postgresql.org

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/14/backup-dump.html
Description:

Hello,
As far as I can see, the terms "Reload" and "Restore" are used
interchangeably.
To make the page as easy digestable for the reader as possible, it´s
advisable to stick to exactly one term.
BR, Axel

#2Laurenz Albe
laurenz.albe@cybertec.at
In reply to: PG Bug reporting form (#1)
Re: "Restore" vs. "Reload"

On Tue, 2022-03-15 at 16:12 +0000, PG Doc comments form wrote:

Page: https://www.postgresql.org/docs/14/backup-dump.html

As far as I can see, the terms "Reload" and "Restore" are used
interchangeably.
To make the page as easy digestable for the reader as possible, it´s
advisable to stick to exactly one term.

That makes sense, particularly since "reload" typically means something
else in PostgreSQL. I think "restore" is better.

Do you feel like preparing a patch?

Yours,
Laurenz Albe

#3Bruce Momjian
bruce@momjian.us
In reply to: Laurenz Albe (#2)
Re: "Restore" vs. "Reload"

On Wed, Mar 16, 2022 at 09:28:04AM +0100, Laurenz Albe wrote:

On Tue, 2022-03-15 at 16:12 +0000, PG Doc comments form wrote:

Page: https://www.postgresql.org/docs/14/backup-dump.html

As far as I can see, the terms "Reload" and "Restore" are used
interchangeably.
To make the page as easy digestable for the reader as possible, it´s
advisable to stick to exactly one term.

That makes sense, particularly since "reload" typically means something
else in PostgreSQL. I think "restore" is better.

Do you feel like preparing a patch?

I have created the attached patch. The only place I left "reload" was
when it was used in pg_dump in "To reload an archive file" and similar
cases. In those cases, restoring a script or file might be
misinterpreted.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Indecision is a decision. Inaction is an action. Mark Batterson

Attachments:

reload.difftext/x-diff; charset=us-asciiDownload+32-32
#4Bruce Momjian
bruce@momjian.us
In reply to: Bruce Momjian (#3)
Re: "Restore" vs. "Reload"

On Thu, Jul 14, 2022 at 07:42:43PM -0400, Bruce Momjian wrote:

On Wed, Mar 16, 2022 at 09:28:04AM +0100, Laurenz Albe wrote:

On Tue, 2022-03-15 at 16:12 +0000, PG Doc comments form wrote:

Page: https://www.postgresql.org/docs/14/backup-dump.html

As far as I can see, the terms "Reload" and "Restore" are used
interchangeably.
To make the page as easy digestable for the reader as possible, it´s
advisable to stick to exactly one term.

That makes sense, particularly since "reload" typically means something
else in PostgreSQL. I think "restore" is better.

Do you feel like preparing a patch?

I have created the attached patch. The only place I left "reload" was
when it was used in pg_dump in "To reload an archive file" and similar
cases. In those cases, restoring a script or file might be
misinterpreted.

Patch applied back to PG 11. PG 10 had too many conflicts.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Indecision is a decision. Inaction is an action. Mark Batterson