Alignment issue at 43.10. Trigger Functions

Started by PG Bug reporting formover 3 years ago4 messagesdocs
Jump to latest
#1PG Bug reporting form
noreply@postgresql.org

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/plpgsql-trigger.html
Description:

Type alignment issue for salary at "Example 43.4. A PL/pgSQL Trigger
Function for Auditing":

CREATE TABLE emp_audit(
operation char(1) NOT NULL,
stamp timestamp NOT NULL,
userid text NOT NULL,
empname text NOT NULL,
salary integer
);

#2Laurenz Albe
laurenz.albe@cybertec.at
In reply to: PG Bug reporting form (#1)
Re: Alignment issue at 43.10. Trigger Functions

On Thu, 2022-11-17 at 18:14 +0000, PG Doc comments form wrote:

Page: https://www.postgresql.org/docs/13/plpgsql-trigger.html

Type alignment issue for salary at "Example 43.4. A PL/pgSQL Trigger
Function for Auditing":

CREATE TABLE emp_audit(
    operation         char(1)   NOT NULL,
    stamp             timestamp NOT NULL,
    userid            text      NOT NULL,
    empname           text      NOT NULL,
    salary integer
);

Attached is a patch to fix that.

Yours,
Laurenz Albe

Attachments:

0001-Fix-text-alignment-in-an-example.patchtext/x-patch; charset=UTF-8; name=0001-Fix-text-alignment-in-an-example.patchDownload+1-2
#3Daniel Gustafsson
daniel@yesql.se
In reply to: Laurenz Albe (#2)
Re: Alignment issue at 43.10. Trigger Functions

On 18 Nov 2022, at 07:21, Laurenz Albe <laurenz.albe@cybertec.at> wrote:

On Thu, 2022-11-17 at 18:14 +0000, PG Doc comments form wrote:

Page: https://www.postgresql.org/docs/13/plpgsql-trigger.html

Type alignment issue for salary at "Example 43.4. A PL/pgSQL Trigger
Function for Auditing":

CREATE TABLE emp_audit(
operation char(1) NOT NULL,
stamp timestamp NOT NULL,
userid text NOT NULL,
empname text NOT NULL,
salary integer
);

Attached is a patch to fix that.

There was a second occurrence of the above, as well as one table which had no
vertical alignment at all. I fixed these and applied your patch to master.

--
Daniel Gustafsson https://vmware.com/

#4Laurenz Albe
laurenz.albe@cybertec.at
In reply to: Daniel Gustafsson (#3)
Re: Alignment issue at 43.10. Trigger Functions

On Fri, 2022-12-02 at 11:42 +0100, Daniel Gustafsson wrote:

I fixed these and applied your patch to master.

Thanks for taking care of this small matter.

Yours,
Laurenz Albe