Change "two" to "three" for decades of development in history

Started by PG Bug reporting formalmost 3 years ago11 messagesdocs
Jump to latest
#1PG Bug reporting form
noreply@postgresql.org

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/15/history.html
Description:

Hi,

In https://www.postgresql.org/docs/current/history.html it is written "With
over two decades of development behind it".
But since "The implementation of POSTGRES began in 1986" according to the
same document, it should now be "With over three decades of development
behind it".

Regards,
Pierre

#2Bruce Momjian
bruce@momjian.us
In reply to: PG Bug reporting form (#1)
Re: Change "two" to "three" for decades of development in history

On Tue, Jun 20, 2023 at 07:36:46AM +0000, PG Doc comments form wrote:

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/15/history.html
Description:

Hi,

In https://www.postgresql.org/docs/current/history.html it is written "With
over two decades of development behind it".
But since "The implementation of POSTGRES began in 1986" according to the
same document, it should now be "With over three decades of development
behind it".

You are _totally_ correct. Attached patch applied back to PG 11. Seems
we will need to change this to "four" in a few years too.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

Attachments:

master.difftext/x-diff; charset=us-asciiDownload+1-1
#3Kirk Parker
khp@equatoria.us
In reply to: Bruce Momjian (#2)
Re: Change "two" to "three" for decades of development in history

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/15/history.html
Description:

Hi,

In https://www.postgresql.org/docs/current/history.html it is written

"With

over two decades of development behind it".
But since "The implementation of POSTGRES began in 1986" according to the
same document, it should now be "With over three decades of development
behind it".

You are _totally_ correct. Attached patch applied back to PG 11. Seems
we will need to change this to "four" in a few years too.

I don't suppose DocBook has macro and system-variable capabilities? That

could provide a set-and-forget solution to this?

#4Bruce Momjian
bruce@momjian.us
In reply to: Kirk Parker (#3)
Re: Change "two" to "three" for decades of development in history

On Thu, Jun 22, 2023 at 01:47:16PM -0700, Kirk Parker wrote:

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/15/history.html
Description:

Hi,

In https://www.postgresql.org/docs/current/history.html it is written

"With

over two decades of development behind it".
But since "The implementation of POSTGRES began in 1986" according to the
same document, it should now be "With over three decades of development
behind it".

You are _totally_ correct.  Attached patch applied back to PG 11.  Seems
we will need to change this to "four" in a few years too.

I don't suppose DocBook has macro and system-variable capabilities? That could
provide a set-and-forget solution to this?

Uh, I am not aware of any.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

#5Erik Wienhold
ewie@ewie.name
In reply to: Bruce Momjian (#4)
Re: Change "two" to "three" for decades of development in history

On 22/06/2023 23:00 CEST Bruce Momjian <bruce@momjian.us> wrote:

On Thu, Jun 22, 2023 at 01:47:16PM -0700, Kirk Parker wrote:

I don't suppose DocBook has macro and system-variable capabilities? That
could provide a set-and-forget solution to this?

Uh, I am not aware of any.

An SGML entity [0]https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/Makefile;h=71cbef230f34a6ad6b41a667c7d2977fb6560378;hb=HEAD#l98 or an xsltproc stringparam [1]https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/Makefile;h=71cbef230f34a6ad6b41a667c7d2977fb6560378;hb=HEAD#l56 looks viable. Question is
how to calculate the number of decades in the Makefile. It's trivial in SQL :)

=# select extract(decade from now()) - extract(decade from date '1986-01-01');
?column?
----------
4
(1 row)

=# select extract(day from now() - date '1986-01-01') / 365.25 / 10;
?column?
--------------------
3.7472963723477071
(1 row)

[0]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/Makefile;h=71cbef230f34a6ad6b41a667c7d2977fb6560378;hb=HEAD#l98
[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/Makefile;h=71cbef230f34a6ad6b41a667c7d2977fb6560378;hb=HEAD#l56

--
Erik

#6Michael Paquier
michael@paquier.xyz
In reply to: Erik Wienhold (#5)
Re: Change "two" to "three" for decades of development in history

On Fri, Jun 23, 2023 at 03:17:26AM +0200, Erik Wienhold wrote:

An SGML entity [0] or an xsltproc stringparam [1] looks viable. Question is
how to calculate the number of decades in the Makefile. It's trivial in SQL :)

-  University of California at Berkeley.  With over two decades of
+  University of California at Berkeley.  With over three decades of
   development behind it, <productname>PostgreSQL</productname> is now
   the most advanced open-source database available anywhere.

Seeing what has been committed, I don't think that such complications
are necessary if this sentence is reworded without numbers. For
instance:
"With multiple decades of development behind it, PostgreSQL.."

My 2c.
--
Michael

#7Tom Lane
tgl@sss.pgh.pa.us
In reply to: Michael Paquier (#6)
Re: Change "two" to "three" for decades of development in history

Michael Paquier <michael@paquier.xyz> writes:

"With multiple decades of development behind it, PostgreSQL.."

+1. It sure seems silly trying to automate changing this.

regards, tom lane

#8Jonathan S. Katz
jkatz@postgresql.org
In reply to: Tom Lane (#7)
Re: Change "two" to "three" for decades of development in history

On 6/22/23 9:23 PM, Tom Lane wrote:

Michael Paquier <michael@paquier.xyz> writes:

"With multiple decades of development behind it, PostgreSQL.."

+1. It sure seems silly trying to automate changing this.

+1. With the proposed language, we can revisit it once it gets to
"centuries."

Jonathan

#9Bruce Momjian
bruce@momjian.us
In reply to: Jonathan S. Katz (#8)
Re: Change "two" to "three" for decades of development in history

On Thu, Jun 22, 2023 at 10:01:45PM -0400, Jonathan Katz wrote:

On 6/22/23 9:23 PM, Tom Lane wrote:

Michael Paquier <michael@paquier.xyz> writes:

"With multiple decades of development behind it, PostgreSQL.."

+1. It sure seems silly trying to automate changing this.

+1. With the proposed language, we can revisit it once it gets to
"centuries."

Applied patch is "With decades of development".

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

#10Michael Paquier
michael@paquier.xyz
In reply to: Bruce Momjian (#9)
Re: Change "two" to "three" for decades of development in history

On Fri, Jun 23, 2023 at 10:50:20PM -0400, Bruce Momjian wrote:

Applied patch is "With decades of development".

Thanks.
--
Michael

#11Pantelis Theodosiou
ypercube@gmail.com
In reply to: Bruce Momjian (#9)
Re: Change "two" to "three" for decades of development in history

On Sat, Jun 24, 2023 at 3:50 AM Bruce Momjian <bruce@momjian.us> wrote:

On Thu, Jun 22, 2023 at 10:01:45PM -0400, Jonathan Katz wrote:

On 6/22/23 9:23 PM, Tom Lane wrote:

Michael Paquier <michael@paquier.xyz> writes:

"With multiple decades of development behind it, PostgreSQL.."

+1. It sure seems silly trying to automate changing this.

+1. With the proposed language, we can revisit it once it gets to
"centuries."

Applied patch is "With decades of development".

+10 :)