correct documentation in set role
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t77476psql -h localhost -U postgresBuilt from patchset v2 (message #2), July 28, 2026 at 12:03 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t77476_2 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t77476_2 && git checkout t77476_2Patchset v2 (message #2) is on t77476_2
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/16/sql-set-role.html
Description:
it is good to mention that:
The specified role_name must be a role that the current session user is a
member of "and has SET True option on it."
The second part missed in documentation for set role command.
On Mon, Sep 25, 2023 at 07:46:18AM +0000, PG Doc comments form wrote:
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/16/sql-set-role.html
Description:it is good to mention that:
The specified role_name must be a role that the current session user is a
member of "and has SET True option on it."
The second part missed in documentation for set role command.
Good point. How is the attached patch?
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
On Tue, Sep 26, 2023 at 11:44:42AM -0400, Bruce Momjian wrote:
On Mon, Sep 25, 2023 at 07:46:18AM +0000, PG Doc comments form wrote:
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/16/sql-set-role.html
Description:it is good to mention that:
The specified role_name must be a role that the current session user is a
member of "and has SET True option on it."
The second part missed in documentation for set role command.Good point. How is the attached patch?
diff --git a/doc/src/sgml/ref/set_role.sgml b/doc/src/sgml/ref/set_role.sgml index 13bad1bf66..a2661945aa 100644 --- a/doc/src/sgml/ref/set_role.sgml +++ b/doc/src/sgml/ref/set_role.sgml @@ -42,7 +42,8 @@ RESET ROLE<para> The specified <replaceable class="parameter">role_name</replaceable> - must be a role that the current session user is a member of. + must be a role that the current session user is a member of and + is granted <literal>WITH SET TRUE</literal>. (If the session user is a superuser, any role can be selected.) </para>
Someone is already working on this text addition from a post yesterday:
/messages/by-id/20230925220945.GB3172533@nathanxps13
Please ignore my patch and I will be sure the patch at this URL gets
committed. Thanks.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.