Minipatch concerning tags

Started by Maxim Yablokovover 2 years ago5 messagesdocs
Jump to latest
#1Maxim Yablokov
m.yablokov@postgrespro.ru

Hello!
PostgresPro documentation team (Ekaterina Kiryanova, Elena Indrupskaya,
Oleg Sibiryakov and me) have prepared a patch with some improvements
concerning missed/inapt tags. Please have a look.

--
Best regards,
Maxim Yablokov
Technical writer-translator
Postgres Professional <https://postgrespro.com/&gt;

Attachments:

tags.patchtext/x-patch; charset=UTF-8; name=tags.patchDownload+22-20
#2Michael Paquier
michael@paquier.xyz
In reply to: Maxim Yablokov (#1)
Re: Minipatch concerning tags

On Fri, Oct 20, 2023 at 11:22:55AM +0300, Maxim Yablokov wrote:

PostgresPro documentation team (Ekaterina Kiryanova, Elena Indrupskaya, Oleg
Sibiryakov and me) have prepared a patch with some improvements concerning
missed/inapt tags. Please have a look.

Most of what you are proposing makes sense.

-     It means that, for walsenders which are lagging (if any), some WAL records up
+     It means that, for <literal>walsender</literal>s that are lagging (if any), 

But not this one. This could just be "WAL senders", but we also use
the term "walsender" in physical and logical replication areas, so a
plural looks OK for me here, leaving it as it is now.
--
Michael

#3Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#2)
Re: Minipatch concerning tags

On Sat, Oct 21, 2023 at 04:11:50PM +0900, Michael Paquier wrote:

But not this one. This could just be "WAL senders", but we also use
the term "walsender" in physical and logical replication areas, so a
plural looks OK for me here, leaving it as it is now.

I have reverted this change, added one markup for a catalog_xmin that
was missed, fixed a few whitespaces, and applied it on HEAD.

Thanks!
--
Michael

#4Maxim Yablokov
m.yablokov@postgrespro.ru
In reply to: Michael Paquier (#3)
Re: Minipatch concerning tags + new spelling/punctuation patch

Hello!

Thanks a lot!

We have also prepared a small patch concerning spelling, punctuation,
etc. We've decided to send it separately, so it'll be easier to review.
Please have a look.

(just in case: e.kiryanova@postgrespro.ru, e.indrupskaya@postgrespro.ru,
o.sibiryakov@postgrespro.ru, m.yablokov@postgrespro.ru)

23.10.2023 04:01, Michael Paquier пишет:

On Sat, Oct 21, 2023 at 04:11:50PM +0900, Michael Paquier wrote:

But not this one. This could just be "WAL senders", but we also use
the term "walsender" in physical and logical replication areas, so a
plural looks OK for me here, leaving it as it is now.

I have reverted this change, added one markup for a catalog_xmin that
was missed, fixed a few whitespaces, and applied it on HEAD.

Thanks!
--
Michael

--
Best regards,
Maxim Yablokov
Technical writer-translator
Postgres Professional <https://postgrespro.com/&gt;

Attachments:

spelling_punctuation.patchtext/x-patch; charset=UTF-8; name=spelling_punctuation.patchDownload+9-9
#5Michael Paquier
michael@paquier.xyz
In reply to: Maxim Yablokov (#4)
Re: Minipatch concerning tags + new spelling/punctuation patch

On Mon, Oct 23, 2023 at 12:33:03PM +0300, Maxim Yablokov wrote:

We have also prepared a small patch concerning spelling, punctuation, etc.
We've decided to send it separately, so it'll be easier to review. Please
have a look.

Yep, these are improvements. So applied and backpatched (all these
applied down to 16, except for one down to 11).

(just in case: e.kiryanova@postgrespro.ru, e.indrupskaya@postgrespro.ru,
o.sibiryakov@postgrespro.ru, m.yablokov@postgrespro.ru)

Thanks for the list. I've used that in the commit message.
--
Michael