Delete description of trigger file

Started by Shinya Katoover 2 years ago4 messagesdocs
Jump to latest
#1Shinya Kato
Shinya11.Kato@oss.nttdata.com

Hi,

Standby database promotion by trigger file creation is no longer
supported from v16, but its description is remained.
So, I created a patch. Do you think?

--
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION

Attachments:

v1-0001-delete-description-of-trigger-file.patchtext/x-diff; name=v1-0001-delete-description-of-trigger-file.patchDownload+1-1
#2Michael Paquier
michael@paquier.xyz
In reply to: Shinya Kato (#1)
Re: Delete description of trigger file

On Fri, Dec 01, 2023 at 11:54:14AM +0900, Shinya Kato wrote:

later disconnected, the standby goes back to step 1 and tries to
restore the file from the archive again. This loop of retries from the
archive, <filename>pg_wal</filename>, and via streaming replication goes on until the server
-    is stopped or failover is triggered by a trigger file.
+    is stopped.

Just removing this information looks incorrect to me, because a
promotion would cause the retries to stop the WAL lookups. Shouldn't
the last part of this sentence be reworded as of a "or is promoted"?
--
Michael

#3Shinya Kato
Shinya11.Kato@oss.nttdata.com
In reply to: Michael Paquier (#2)
Re: Delete description of trigger file

On 2023-12-01 16:01, Michael Paquier wrote:

On Fri, Dec 01, 2023 at 11:54:14AM +0900, Shinya Kato wrote:

later disconnected, the standby goes back to step 1 and tries to
restore the file from the archive again. This loop of retries 
from the
archive, <filename>pg_wal</filename>, and via streaming 
replication goes on until the server
-    is stopped or failover is triggered by a trigger file.
+    is stopped.

Just removing this information looks incorrect to me, because a
promotion would cause the retries to stop the WAL lookups. Shouldn't
the last part of this sentence be reworded as of a "or is promoted"?

Thanks for the review.
Yes, that's true. A new patch is attached.

--
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION

Attachments:

v2-0001-delete-description-of-trigger-file.patchtext/x-diff; name=v2-0001-delete-description-of-trigger-file.patchDownload+1-1
#4Michael Paquier
michael@paquier.xyz
In reply to: Shinya Kato (#3)
Re: Delete description of trigger file

On Sat, Dec 02, 2023 at 05:52:50PM +0900, Shinya Kato wrote:

Thanks for the review.
Yes, that's true. A new patch is attached.

Thanks, applied.
--
Michael