Fix analyze_sampling docs in postgres-fdw.sgml

Started by Shinya Katoabout 2 years ago3 messagesdocs
Jump to latest
#1Shinya Kato
Shinya11.Kato@oss.nttdata.com

Hi!

I fixed analyze_sampling docs in postgres-fdw.sgml.
- Changed analyze_sampling type 'text' to 'string'
- Add a statement 'The option specified on a table overrides an option
specified for the server.'

Do you think?

Regards,
Shinya Kato
NTT DATA GROUP CORPORATION

Attachments:

v1-0001-fix-analyze_sampling-docs.patchtext/x-diff; name=v1-0001-fix-analyze_sampling-docs.patchDownload+3-2
#2Laurenz Albe
laurenz.albe@cybertec.at
In reply to: Shinya Kato (#1)
Re: Fix analyze_sampling docs in postgres-fdw.sgml

On Mon, 2024-03-04 at 14:27 +0900, Shinya Kato wrote:

I fixed analyze_sampling docs in postgres-fdw.sgml.
- Changed analyze_sampling type 'text' to 'string'

+1

- Add a statement 'The option specified on a table overrides an option
specified for the server.'

I think that applies to all options. It would be better to have a general
statement to that effect at the beginning of the "Options" section.

Yours,
Laurenz Albe

#3Daniel Gustafsson
daniel@yesql.se
In reply to: Laurenz Albe (#2)
Re: Fix analyze_sampling docs in postgres-fdw.sgml

On 4 Mar 2024, at 09:37, Laurenz Albe <laurenz.albe@cybertec.at> wrote:

On Mon, 2024-03-04 at 14:27 +0900, Shinya Kato wrote:

I fixed analyze_sampling docs in postgres-fdw.sgml.
- Changed analyze_sampling type 'text' to 'string'

+1

Agreed, that should be changed, will fix.

- Add a statement 'The option specified on a table overrides an option
specified for the server.'

I think that applies to all options. It would be better to have a general
statement to that effect at the beginning of the "Options" section.

Yeah, that might be a good idead.

--
Daniel Gustafsson