correction

Started by PG Bug reporting formover 1 year ago2 messagesdocs
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t77779
psql -h localhost -U postgres

Built from patchset v2 (message #2), July 27, 2026 at 10:13 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t77779_2 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t77779_2 && git checkout t77779_2

Patchset v2 (message #2) is on t77779_2

Jump to latest
#1PG Bug reporting form
noreply@postgresql.org

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/17/routine-vacuuming.html
Description:

hi i found a tiny error below:
https://www.postgresql.org/docs/current/routine-vacuuming.html

Drop any old replication slots. Use pg_stat_replication to find slots where

age(xmin) or age(catalog_xmin) is large. In many cases, such slots were
created for replication to servers that no longer exist, or that have been
down for a long time.

not pg_stat_replication but pg_replication_slots
because pg_stat_replication has neither
xmin nor catalog_xmin.

thank you

#2Euler Taveira
euler@eulerto.com
In reply to: PG Bug reporting form (#1)
Re: correction

On Mon, Feb 24, 2025, at 3:52 AM, PG Doc comments form wrote:

hi i found a tiny error below:
https://www.postgresql.org/docs/current/routine-vacuuming.html

Drop any old replication slots. Use pg_stat_replication to find slots where

age(xmin) or age(catalog_xmin) is large. In many cases, such slots were
created for replication to servers that no longer exist, or that have been
down for a long time.

not pg_stat_replication but pg_replication_slots
because pg_stat_replication has neither
xmin nor catalog_xmin.

Good catch! This seems an oversight in commit a70bce43fbc that was
backpatched down to v14. The attached patch should fix it.

--
Euler Taveira
EDB https://www.enterprisedb.com/

Attachments:

t77779_2
doc-fix.patchtext/x-patch; name=doc-fix.patchDownload+2-2