Remove unnecessary secondary index terms for replication settings
Hi,
In config.sgml, the entries for max_replication_slots and
max_active_replication_origins include secondary index terms:
<primary><varname>max_replication_slots</varname> configuration parameter</primary>
<secondary>in a sending server</secondary>
<primary><varname>max_active_replication_origins</varname> configuration parameter</primary>
<secondary>in a subscriber</secondary>
These secondary terms don't seem necessary anymore, since each parameter
now has only one index entry. Removing them would simplify the documentation.
Originally, the secondary entries made sense because
max_active_replication_origins was part of max_replication_slots,
so both needed separate index entries. But commit 04ff636cbce
split them into distinct parameters.
Patch attached.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachments:
v1-0001-doc-remove-unnecessary-secondary-index-terms-for-.patchtext/plain; charset=UTF-8; name=v1-0001-doc-remove-unnecessary-secondary-index-terms-for-.patchDownload+0-3
On Wed, Apr 23, 2025, at 3:53 AM, Fujii Masao wrote:
These secondary terms don't seem necessary anymore, since each parameter
now has only one index entry. Removing them would simplify the documentation.Originally, the secondary entries made sense because
max_active_replication_origins was part of max_replication_slots,
so both needed separate index entries. But commit 04ff636cbce
split them into distinct parameters.
Agreed. It was an oversight in my patch. LGTM.
--
Euler Taveira
EDB https://www.enterprisedb.com/
On Wed, Apr 23, 2025 at 2:54 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
Hi,
In config.sgml, the entries for max_replication_slots and
max_active_replication_origins include secondary index terms:<primary><varname>max_replication_slots</varname> configuration parameter</primary>
<secondary>in a sending server</secondary><primary><varname>max_active_replication_origins</varname> configuration parameter</primary>
<secondary>in a subscriber</secondary>These secondary terms don't seem necessary anymore, since each parameter
now has only one index entry. Removing them would simplify the documentation.Originally, the secondary entries made sense because
max_active_replication_origins was part of max_replication_slots,
so both needed separate index entries. But commit 04ff636cbce
split them into distinct parameters.Patch attached.
Make sense, +1 from me.
Robert Treat
https://xzilla.net
On 2025/04/24 23:30, Robert Treat wrote:
On Wed, Apr 23, 2025 at 2:54 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
Hi,
In config.sgml, the entries for max_replication_slots and
max_active_replication_origins include secondary index terms:<primary><varname>max_replication_slots</varname> configuration parameter</primary>
<secondary>in a sending server</secondary><primary><varname>max_active_replication_origins</varname> configuration parameter</primary>
<secondary>in a subscriber</secondary>These secondary terms don't seem necessary anymore, since each parameter
now has only one index entry. Removing them would simplify the documentation.Originally, the secondary entries made sense because
max_active_replication_origins was part of max_replication_slots,
so both needed separate index entries. But commit 04ff636cbce
split them into distinct parameters.Patch attached.
Make sense, +1 from me.
Thanks both for the review! I've pushed the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION