Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs
Hi,
Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE.
In this feature, since indexes are not created for foreign tables,
comments on indexes are not copied either.
However, the CREATE FOREIGN TABLE docs incorrectly states that
index comments are copied when using INCLUDING COMMENTS, as shown below:
------------------------------
INCLUDING COMMENTS
Comments for the copied columns, constraints, and indexes will be copied.
------------------------------
This isn't accurate for foreign tables, so we should remove the mention
of indexes. Patch attached.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
Attachments:
v1-0001-doc-Fix-incorrect-description-of-INCLUDING-COMMEN.patchtext/plain; charset=UTF-8; name=v1-0001-doc-Fix-incorrect-description-of-INCLUDING-COMMEN.patchDownload+1-2
On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote:
Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE.
In this feature, since indexes are not created for foreign tables,
comments on indexes are not copied either.
Good point. This doc fix sounds fine to me.
--
Michael
On 2025/06/18 15:50, Michael Paquier wrote:
On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote:
Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE.
In this feature, since indexes are not created for foreign tables,
comments on indexes are not copied either.Good point. This doc fix sounds fine to me.
Thanks for the review! I will commit the patch barring any other objections.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
On 2025/06/18 16:55, Fujii Masao wrote:
On 2025/06/18 15:50, Michael Paquier wrote:
On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote:
Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE.
In this feature, since indexes are not created for foreign tables,
comments on indexes are not copied either.Good point. This doc fix sounds fine to me.
Thanks for the review! I will commit the patch barring any other objections.
I've pushed the patch. Thanks!
Regards,
--
Fujii Masao
NTT DATA Japan Corporation