doc: Fix the header file where CompareType is defined in gist.sgml

Started by Daisuke Higuchi4 months ago3 messagesdocs
Jump to latest
#1Daisuke Higuchi
higuchi.daisuke11@gmail.com

Hi

I found that the header file where CompareType was actually defined did not
match the header file described in gist.sgml.
CompareType is currently defined at "src/include/access/cmptype.h" instead
of "src/include/nodes/primnodes.h".
This change was made in the commit below, but it seems that documentation
update was missed.

https://github.com/postgres/postgres/commit/119fc30dd5bd918819b864107ddc8baac51f4d22

Regards

Attachments:

gist_doc.patchapplication/octet-stream; name=gist_doc.patchDownload+2-2
#2Paul Jungwirth
pj@illuminatedcomputing.com
In reply to: Daisuke Higuchi (#1)
Re: doc: Fix the header file where CompareType is defined in gist.sgml

On Sat, Dec 13, 2025 at 12:25 AM Daisuke Higuchi
<higuchi.daisuke11@gmail.com> wrote:

I found that the header file where CompareType was actually defined did not match the header file described in gist.sgml.
CompareType is currently defined at "src/include/access/cmptype.h" instead of "src/include/nodes/primnodes.h".
This change was made in the commit below, but it seems that documentation update was missed.

https://github.com/postgres/postgres/commit/119fc30dd5bd918819b864107ddc8baac51f4d22

You're right, that's where we define it. Your email landed in Gmail's
spam folder for me, so hopefully this +1 will help it not be missed by
a committer.

Yours,

--
Paul ~{:-)
pj@illuminatedcomputing.com

#3Daniel Gustafsson
daniel@yesql.se
In reply to: Paul Jungwirth (#2)
Re: doc: Fix the header file where CompareType is defined in gist.sgml

On 16 Dec 2025, at 00:19, Paul A Jungwirth <pj@illuminatedcomputing.com> wrote:

On Sat, Dec 13, 2025 at 12:25 AM Daisuke Higuchi
<higuchi.daisuke11@gmail.com> wrote:

I found that the header file where CompareType was actually defined did not match the header file described in gist.sgml.
CompareType is currently defined at "src/include/access/cmptype.h" instead of "src/include/nodes/primnodes.h".
This change was made in the commit below, but it seems that documentation update was missed.

https://github.com/postgres/postgres/commit/119fc30dd5bd918819b864107ddc8baac51f4d22

You're right, that's where we define it. Your email landed in Gmail's
spam folder for me, so hopefully this +1 will help it not be missed by
a committer.

Thanks for the report, fixing it right now.

--
Daniel Gustafsson