Clarify INCLUDING COMMENTS behavior in CREATE TABLE and CREATE FOREIGN TABLE docs

Started by Fujii Masaoabout 2 months ago4 messagesdocs
Jump to latest
#1Fujii Masao
masao.fujii@gmail.com

Hi,

Comments for the copied columns, constraints, and indexes will be copied.

The above current description of INCLUDING COMMENTS in the CREATE TABLE docs
appears inaccurate and incomplete. It says that comments on constraints are
copied, but in practice only comments on CHECK and NOT NULL constraints
are copied; comments on other constraints (such as primary keys) are not.
In addition, comments on extended statistics are copied, but this is not
documented.

The CREATE FOREIGN TABLE docs has a similar omission: comments on extended
statistics are also copied, but this is not mentioned.

Therefore I'd like to propose the attached patch to clarify the actual behavior
of INCLUDING COMMENTS. Thoughts?

Regards,

--
Fujii Masao

Attachments:

v1-0001-doc-Clarify-INCLUDING-COMMENTS-behavior-in-CREATE.patchapplication/octet-stream; name=v1-0001-doc-Clarify-INCLUDING-COMMENTS-behavior-in-CREATE.patchDownload+6-6
#2Matheus Alcantara
matheusssilv97@gmail.com
In reply to: Fujii Masao (#1)
Re: Clarify INCLUDING COMMENTS behavior in CREATE TABLE and CREATE FOREIGN TABLE docs

On Tue Feb 17, 2026 at 11:36 AM -03, Fujii Masao wrote:

Hi,

Comments for the copied columns, constraints, and indexes will be copied.

The above current description of INCLUDING COMMENTS in the CREATE TABLE docs
appears inaccurate and incomplete. It says that comments on constraints are
copied, but in practice only comments on CHECK and NOT NULL constraints
are copied; comments on other constraints (such as primary keys) are not.
In addition, comments on extended statistics are copied, but this is not
documented.

The CREATE FOREIGN TABLE docs has a similar omission: comments on extended
statistics are also copied, but this is not mentioned.

Therefore I'd like to propose the attached patch to clarify the actual behavior
of INCLUDING COMMENTS. Thoughts?

Hi, thanks for the patch.

The changes make sense to me, it sounds more clear. I've performed some
tests and the documentation seems correct about what comments are
actually copied.

--
Matheus Alcantara
EDB: https://www.enterprisedb.com

#3Fujii Masao
masao.fujii@gmail.com
In reply to: Matheus Alcantara (#2)
Re: Clarify INCLUDING COMMENTS behavior in CREATE TABLE and CREATE FOREIGN TABLE docs

On Fri, Feb 20, 2026 at 12:10 AM Matheus Alcantara
<matheusssilv97@gmail.com> wrote:

On Tue Feb 17, 2026 at 11:36 AM -03, Fujii Masao wrote:

Hi,

Comments for the copied columns, constraints, and indexes will be copied.

The above current description of INCLUDING COMMENTS in the CREATE TABLE docs
appears inaccurate and incomplete. It says that comments on constraints are
copied, but in practice only comments on CHECK and NOT NULL constraints
are copied; comments on other constraints (such as primary keys) are not.
In addition, comments on extended statistics are copied, but this is not
documented.

The CREATE FOREIGN TABLE docs has a similar omission: comments on extended
statistics are also copied, but this is not mentioned.

Therefore I'd like to propose the attached patch to clarify the actual behavior
of INCLUDING COMMENTS. Thoughts?

Hi, thanks for the patch.

The changes make sense to me, it sounds more clear. I've performed some
tests and the documentation seems correct about what comments are
actually copied.

Thanks for the review! Barring any objections, I will commit the patch.

Regards,

--
Fujii Masao

#4Fujii Masao
masao.fujii@gmail.com
In reply to: Fujii Masao (#3)
Re: Clarify INCLUDING COMMENTS behavior in CREATE TABLE and CREATE FOREIGN TABLE docs

On Fri, Feb 20, 2026 at 12:51 AM Fujii Masao <masao.fujii@gmail.com> wrote:

Thanks for the review! Barring any objections, I will commit the patch.

I've pushed the patch. Thanks!

Regards,

--
Fujii Masao