no history in psql on OpenBSD
hello,
i use PostgreSQL on OpenBSD (various systems, including 2.5-2.8 beta)
and like it much. one thing, i have to make hand changes to source
(namely to src/bin/psql/input.h) to make _existing in system_ readline's
history working... the point is that for OpenBSD autconf finds and
defines HAVE_READLINE_READLINE_H and HAVE_LIBREADLINE and
HAVE_HISTORY_IN_READLINE, but there's no history.h in the system, thus
HAVE_READLINE_HISTORY_H nor HAVE_HISTORY_H aren't defined. So,
USE_HISTORY doesn't gets defined. Wouldn't it be good to patch the
input.h with something like:
--- input.h.orig Wed Nov 15 17:24:15 2000
+++ input.h Wed Nov 15 17:25:28 2000
@@ -27,11 +27,10 @@
#if defined(HAVE_LIBHISTORY) || (defined(HAVE_LIBREADLINE) && defined(HAVE_HISTORY_IN_READLINE))
#if defined(HAVE_READLINE_HISTORY_H)
#include <readline/history.h>
-#define USE_HISTORY 1
#elif defined(HAVE_HISTORY_H)
#include <history.h>
-#define USE_HISTORY 1
#endif
+#define USE_HISTORY 1
#endifchar *gets_interactive(char *prompt);
works fine for me... and seems to be logical :-)
--
Denis A. Doroshenko -- VAS/IN group engineer .-. _|_ |
[Omnitel Ltd., T.Sevcenkos st. 25, Vilnius, Lithuania] | | _ _ _ .| _ |
[Phone: +370 9863207 E-mail: d.doroshenko@omnitel.net] |_|| | || |||(/_|_
Denis A. Doroshenko writes:
i use PostgreSQL on OpenBSD (various systems, including 2.5-2.8 beta)
and like it much. one thing, i have to make hand changes to source
(namely to src/bin/psql/input.h) to make _existing in system_ readline's
history working... the point is that for OpenBSD autconf finds and
defines HAVE_READLINE_READLINE_H and HAVE_LIBREADLINE and
HAVE_HISTORY_IN_READLINE, but there's no history.h in the system, thus
HAVE_READLINE_HISTORY_H nor HAVE_HISTORY_H aren't defined.
But does readline.h declare the history functions? In any case I'd
contact the package maintainer and ask him to install the history.h
file. It belongs to readline, and OpenBSD is the only system causing
problems with this.
--
Peter Eisentraut peter_e@gmx.net http://yi.org/peter-e/
On Wed, Nov 15, 2000 at 05:44:25PM +0100, Peter Eisentraut wrote:
Denis A. Doroshenko writes:
i use PostgreSQL on OpenBSD (various systems, including 2.5-2.8 beta)
and like it much. one thing, i have to make hand changes to source
(namely to src/bin/psql/input.h) to make _existing in system_ readline's
history working... the point is that for OpenBSD autconf finds and
defines HAVE_READLINE_READLINE_H and HAVE_LIBREADLINE and
HAVE_HISTORY_IN_READLINE, but there's no history.h in the system, thus
HAVE_READLINE_HISTORY_H nor HAVE_HISTORY_H aren't defined.But does readline.h declare the history functions? In any case I'd
contact the package maintainer and ask him to install the history.h
file.
uhm... ok, i may understand your point, but hey, read the defines'
names and doesn't it seem to be logical if
HAVE_READLINE_READLINE_H
HAVE_LIBREADLINE
HAVE_HISTORY_IN_READLINE
are defined, then define USE_HISTORY?? the last of the three
explicitly defines there's history support...
It belongs to readline, and OpenBSD is the only system causing
problems with this.
yes, OpenBSD is very picky about including tons of features in the
world, and GNU's ones as well :-)
--
Denis A. Doroshenko -- VAS/IN group engineer .-. _|_ |
[Omnitel Ltd., T.Sevcenkos st. 25, Vilnius, Lithuania] | | _ _ _ .| _ |
[Phone: +370 9863207 E-mail: d.doroshenko@omnitel.net] |_|| | || |||(/_|_