[PATCH] Partial indices final?

Martijn van Oosterhout <kleptog@svana.org> writes:

OK, I've changed the vacuum code now so your index doesn't get
departialised. The changes seem pretty obvious so they're probably right.
They certainly didn't seem to break my simple tests. How does one test that
VACUUM works properly?

Since I'm just about to start doing some rearrangements of the VACUUM
code, I'll first go ahead and apply the changes to make VACUUM use
ExecOpenIndices. I've wanted to make that change for quite awhile,
independently of partial-index considerations, but had not gotten around
to doing it.

The rest of this should probably be sent to pgsql-patches for more
review.

regards, tom lane

This is all applied, right?

OK, I've changed the vacuum code now so your index doesn't get
departialised. The changes seem pretty obvious so they're probably right.
They certainly didn't seem to break my simple tests. How does one test that
VACUUM works properly?

I think it's time to send it to pgsql-patches now, unless someone spots a
serious problem.

http://svana.org/kleptog/pgsql/partial-indices-7.2.patch

Anyway, now it's time to think about after. I can think of:
* Complete the removal of EXTEND INDEX
* Allow IS NULL in the predicate

Anything else?
--
Martijn van Oosterhout <kleptog@svana.org>
http://svana.org/kleptog/

It would be nice if someone came up with a certification system that
actually separated those who can barely regurgitate what they crammed over
the last few weeks from those who command secret ninja networking powers.

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/users-lounge/docs/faq.html

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

On Wed, Sep 05, 2001 at 12:30:33AM -0400, Bruce Momjian wrote:

This is all applied, right?

Yep. I'm pretty sure Tom included it. At least diffing my CVS tree no longer
shows it...

--
Martijn van Oosterhout <kleptog@svana.org>
http://svana.org/kleptog/