pg_config Makefile includes hyphens in configure arguments

Started by Joel Burtonover 23 years ago2 messages
#1Joel Burton
joel@joelburton.com

Feeding `pg_config --configure` into configure no longer works, as the
output of `pg_config --configure` now includes hypens (as in
"'--enable-cassert' '--enable-debug'"), which configure rejects.

This appears to come from the change in the Makefile
(/src/bin/pg_config/Makefile), where

diff -r1.3 -r1.4
1c1
< # $Header: /projects/cvsroot/pgsql/src/bin/pg_config/Makefile,v 1.3
2001/09/16 16:11:11 petere Exp $
---

# $Header: /projects/cvsroot/pgsql/src/bin/pg_config/Makefile,v 1.4

2002/03/29 17:32:55 petere Exp $
16c15
< -e "s,@configure@,$$configure,g" \
---

-e "s,@configure@,$(configure_args),g" \

Is there a reason to keep this change if it breaks this feature, or is there
an easy way to fix this? (I'm not a serious Makefile user, sorry!)

Thanks!

Joel BURTON | joel@joelburton.com | joelburton.com | aim: wjoelburton
Knowledge Management & Technology Consultant

#2Peter Eisentraut
peter_e@gmx.net
In reply to: Joel Burton (#1)
Re: pg_config Makefile includes hyphens in configure arguments

Joel Burton writes:

Feeding `pg_config --configure` into configure no longer works, as the
output of `pg_config --configure` now includes hypens (as in
"'--enable-cassert' '--enable-debug'"), which configure rejects.

[ apostrophes, I assume ]

Try

eval configure `pg_config --configure`

This allows correct behaviour with arguments that contain spaces.

--
Peter Eisentraut peter_e@gmx.net