Participants
Bruce Momjian
Bruce Momjian
Tom Lane
Tom Lane
Thomas Lockhart
Thomas Lockhart
Attachments

No attachments in this thread

Thread Outline
#1Bruce MomjianBruce Momjian
Aug 16, 2002
#2Tom Lane↳Tom Laneto Bruce Momjian (#1)
Aug 17, 2002
#3Bruce Momjian↳Bruce Momjianto Tom Lane (#2)
Aug 17, 2002
#4Thomas Lockhart↳Thomas Lockhartto Bruce Momjian (#3)
Aug 20, 2002
#5Bruce Momjian↳Bruce Momjianto Thomas Lockhart (#4)
Aug 20, 2002

XLogDir

Started by Bruce Momjianover 23 years ago5 messages
#1Bruce Momjian
Bruce Momjian
pgman@candle.pha.pa.us

A recent change made XLogDir dynamically sized. There was a question of
whether this was a good idea since there are lots of other places that
use MAXPGPATH.

I have now found that pg_resetxlog doesn't compile anymore because
XLogDir is a char* now instead of a char[].

Should I fix pg_resetxlog or revert the XLogDir change in the backend.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#2Tom Lane
Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#1)
Re: XLogDir

Bruce Momjian <pgman@candle.pha.pa.us> writes:

A recent change made XLogDir dynamically sized. There was a question of
whether this was a good idea since there are lots of other places that
use MAXPGPATH.

I have now found that pg_resetxlog doesn't compile anymore because
XLogDir is a char* now instead of a char[].

Should I fix pg_resetxlog or revert the XLogDir change in the backend.

Revert. The XLogDir change was incomplete and basically useless to
start with ...

regards, tom lane

#3Bruce Momjian
Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Tom Lane (#2)
Re: XLogDir

Tom Lane wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

A recent change made XLogDir dynamically sized. There was a question of
whether this was a good idea since there are lots of other places that
use MAXPGPATH.

I have now found that pg_resetxlog doesn't compile anymore because
XLogDir is a char* now instead of a char[].

Should I fix pg_resetxlog or revert the XLogDir change in the backend.

Revert. The XLogDir change was incomplete and basically useless to
start with ...

Yea, but it was tied into the PGXLOG commit. Thomas, what are we doing
with that?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#4Thomas Lockhart
Thomas Lockhart
lockhart@fourpalms.org
In reply to: Bruce Momjian (#3)
Re: XLogDir

Revert. The XLogDir change was incomplete and basically useless to
start with ...

Yea, but it was tied into the PGXLOG commit. Thomas, what are we doing
with that?

Why ask me?

- Thomas

#5Bruce Momjian
Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Thomas Lockhart (#4)
Re: XLogDir

Thomas Lockhart wrote:

Revert. The XLogDir change was incomplete and basically useless to
start with ...

Yea, but it was tied into the PGXLOG commit. Thomas, what are we doing
with that?

Why ask me?

Sorry, I mean XLOGDIR. Somehow I kept saying PGXLOG. Anyway, it is all
out and we can re-add as needed.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
← Back to Topics