Making pg_dump cvs friendly

Started by Jonathan Bartlettalmost 23 years ago7 messagesgeneral
Jump to latest
#1Jonathan Bartlett
johnnyb@eskimo.com

I have created a patch to postgresql 7.3.3 to make pg_dump more CVS
friendly. Basically, pg_dump numbers all of it's TOC entries. Therefore,
if you modify or recreate a view that used to be at the beginning, then
ALL of your tables/indexes/etc get renumbered, which causes a lot of junk
in your CVS.

Anyway, the patch is at

http://www.eskimo.com/~johnnyb/pgdump-cvs-patch.diff

Comments welcome, but this is my first patch, so please be gentle :)

Jon

#2Bruce Momjian
bruce@momjian.us
In reply to: Jonathan Bartlett (#1)
Re: [GENERAL] Making pg_dump cvs friendly

This has been saved for the 7.5 release:

http:/momjian.postgresql.org/cgi-bin/pgpatches2

I will probably merge those two options into a single option.

---------------------------------------------------------------------------

Jonathan Bartlett wrote:

I have created a patch to postgresql 7.3.3 to make pg_dump more CVS
friendly. Basically, pg_dump numbers all of it's TOC entries. Therefore,
if you modify or recreate a view that used to be at the beginning, then
ALL of your tables/indexes/etc get renumbered, which causes a lot of junk
in your CVS.

Anyway, the patch is at

http://www.eskimo.com/~johnnyb/pgdump-cvs-patch.diff

Comments welcome, but this is my first patch, so please be gentle :)

Jon

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Attachments:

/bjm/pgdump-cvs-patch.difftext/plainDownload+57-6
#3Jonathan Bartlett
johnnyb@eskimo.com
In reply to: Bruce Momjian (#2)
Re: [GENERAL] Making pg_dump cvs friendly

Excellent! Thanks!

JOn

On Tue, 22 Jul 2003, Bruce Momjian wrote:

Show quoted text

This has been saved for the 7.5 release:

http:/momjian.postgresql.org/cgi-bin/pgpatches2

I will probably merge those two options into a single option.

---------------------------------------------------------------------------

Jonathan Bartlett wrote:

I have created a patch to postgresql 7.3.3 to make pg_dump more CVS
friendly. Basically, pg_dump numbers all of it's TOC entries. Therefore,
if you modify or recreate a view that used to be at the beginning, then
ALL of your tables/indexes/etc get renumbered, which causes a lot of junk
in your CVS.

Anyway, the patch is at

http://www.eskimo.com/~johnnyb/pgdump-cvs-patch.diff

Comments welcome, but this is my first patch, so please be gentle :)

Jon

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

--
Bruce Momjian                        |  http://candle.pha.pa.us
pgman@candle.pha.pa.us               |  (610) 359-1001
+  If your life is a hard drive,     |  13 Roberts Road
+  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#4Bruce Momjian
bruce@momjian.us
In reply to: Jonathan Bartlett (#1)
Re: Making pg_dump cvs friendly

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

I will merge the two options into one and update the docs accordingly.

---------------------------------------------------------------------------

Jonathan Bartlett wrote:

I have created a patch to postgresql 7.3.3 to make pg_dump more CVS
friendly. Basically, pg_dump numbers all of it's TOC entries. Therefore,
if you modify or recreate a view that used to be at the beginning, then
ALL of your tables/indexes/etc get renumbered, which causes a lot of junk
in your CVS.

Anyway, the patch is at

http://www.eskimo.com/~johnnyb/pgdump-cvs-patch.diff

Comments welcome, but this is my first patch, so please be gentle :)

Jon

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#5Peter Eisentraut
peter_e@gmx.net
In reply to: Bruce Momjian (#4)
Re: Making pg_dump cvs friendly

Bruce Momjian writes:

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

I will merge the two options into one and update the docs accordingly.

I don't think we need to the short option. -m doesn't make sense. The
documentation belongs in the pg_dump reference page, not backup.sgml. The
help text of the option should be adjusted to look more like the adjacent
texts. References to CVS don't belong into the --help output.

--
Peter Eisentraut peter_e@gmx.net

#6Bruce Momjian
bruce@momjian.us
In reply to: Peter Eisentraut (#5)
Re: Making pg_dump cvs friendly

Peter Eisentraut wrote:

Bruce Momjian writes:

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

I will merge the two options into one and update the docs accordingly.

I don't think we need to the short option. -m doesn't make sense. The

Do we actually have flags that can only be specified by long ars? If
so, I don't see any in pg_dump or psql.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#7Bruce Momjian
bruce@momjian.us
In reply to: Jonathan Bartlett (#1)
Re: Making pg_dump cvs friendly

Jonathan Bartlett wrote:

I have created a patch to postgresql 7.3.3 to make pg_dump more CVS
friendly. Basically, pg_dump numbers all of it's TOC entries. Therefore,
if you modify or recreate a view that used to be at the beginning, then
ALL of your tables/indexes/etc get renumbered, which causes a lot of junk
in your CVS.

Anyway, the patch is at

http://www.eskimo.com/~johnnyb/pgdump-cvs-patch.diff

Comments welcome, but this is my first patch, so please be gentle :)

7.5 will no longer output TOC numbers or oids unless you specify
--verbose in the dump, so these new pg_dump options are no longer
required. Thanks.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073