change NAMEDATALEN to 64

I think I figured out what went wrong.

regression.diffs is created by compareing src/test/regress/expect/name.out with
src/test/regress/results/name.out.

Since expected/name.out comes with the jar, so any changes I made won't be
reflected in the that file.

Now the question is, is there a way to update the expected/*out files ??

thanks,
kathy

X-Original-To: pgsql-general-postgresql.org@localhost.postgresql.org
Date: Mon, 14 Jul 2003 16:10:15 -0600 (MDT)
From: Kathy Zhu <Kathy.Zhu@sun.com>
Subject: [GENERAL] change NAMEDATALEN to 64
To: pgsql-general@postgresql.org
X-Virus-Scanned: by amavisd-new at postgresql.org

Hi,

We have tables with long names so I modified postgres_ext.h and change
NAMEDATALEN to 64 (originally is 32).

When I do "gmake check", I failed the test on "name", see below.

parallel group (13 tests): float8 boolean float4 oid int4 int8 char int2 name

t

ext varchar bit numeric
boolean ... ok
char ... ok
name ... FAILED
varchar ... ok
text ... ok
int2 ... ok
int4 ... ok
int8 ... ok
oid ... ok
float4 ... ok
float8 ... ok
bit ... ok
numeric ... ok
test strings ... ok

I am attaching the regression.diffs file created by the regression test, which

I

On Mon, Jul 14, 2003 at 04:10:15PM -0600, Kathy Zhu wrote:

parallel group (13 tests): float8 boolean float4 oid int4 int8 char int2 name t
ext varchar bit numeric
boolean ... ok
char ... ok
name ... FAILED

I am attaching the regression.diffs file created by the regression test, which I
don't know how to interprate.

**** The question is, is it ok to fail this regression test since I do change
the NAMEDATALEN ???

AFAICS this is testing the ability to correctly truncate the identifier
length to 31 chars, so yes, the test is supposed to fail.

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"Linux transform� mi computadora, de una `m�quina para hacer cosas',
en un aparato realmente entretenido, sobre el cual cada d�a aprendo
algo nuevo" (Jaime Salinas)

Alvaro Herrera <alvherre@dcc.uchile.cl> writes:

On Mon, Jul 14, 2003 at 04:10:15PM -0600, Kathy Zhu wrote:

**** The question is, is it ok to fail this regression test since I do change
the NAMEDATALEN ???

AFAICS this is testing the ability to correctly truncate the identifier
length to 31 chars, so yes, the test is supposed to fail.

Indeed; see the changes to that regression result made between 7.2 and 7.3:
http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/test/regress/expected/name.out

Kathy, you might want to think about switching to a not-yet-obsolete
release ;-)

regards, tom lane