Re: [COMMITTERS] pgsql/contrib/rserv ApplySnapshot.in CleanLog. ...
Peter, the author is questioning why his Makefile changes were wrong.
Would you elaborate?
---------------------------------------------------------------------------
pgman wrote:
Done.
---------------------------------------------------------------------------
Peter Eisentraut wrote:
Please revert the Makefile part of this patch.
Bruce Momjian - CVS writes:
CVSROOT: /cvsroot
Module name: pgsql
Changes by: momjian@postgresql.org 02/03/06 15:41:38Modified files:
contrib/rserv : ApplySnapshot.in CleanLog.in GetSyncID.in
Makefile MasterSync.in PrepareSnapshot.in
Replicate.inLog message:
This simple patch fixes broken Makefile, broken ApplySnapshot and
makes all utilities honour --verbose command line option.--
Yours, Alexey V. Borzov, Webmaster of RDW.ru--
Peter Eisentraut peter_e@gmx.net---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?-- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073Import Notes
Reply to msg id not found:
Bruce Momjian writes:
Peter, the author is questioning why his Makefile changes were wrong.
Would you elaborate?
Because we rely on the built-in library lookup functionality instead of
hardcoding the full file name.
--
Peter Eisentraut peter_e@gmx.net
Hello Peter,
Tuesday, October 01, 2002, 1:42:46 AM, you wrote:
PE> Bruce Momjian writes:
Peter, the author is questioning why his Makefile changes were wrong.
Would you elaborate?
PE> Because we rely on the built-in library lookup functionality instead of
PE> hardcoding the full file name.
Agh! I finally read up on module loading
http://developer.postgresql.org/docs/postgres/xfunc-c.html#XFUNC-C-DYNLOAD
and now I seem to understand. You see, the problem with the current
Makefile is as follows: it substitutes '$libdir' into both .sql and
perl files. While this is good enough for sql, $libdir is consumed
by Perl and thus perl scripts do NOT work.
Thanks for elaborating, I'll try to produce a better patch ASAP.
--
пїЅ пїЅпїЅпїЅпїЅпїЅпїЅпїЅпїЅпїЅ, пїЅпїЅпїЅпїЅпїЅпїЅпїЅ пїЅпїЅпїЅпїЅпїЅпїЅ
пїЅпїЅпїЅпїЅпїЅ пїЅпїЅпїЅпїЅпїЅпїЅпїЅпїЅ-пїЅпїЅпїЅпїЅпїЅпїЅпїЅпїЅ пїЅпїЅпїЅ "пїЅпїЅпїЅ-пїЅпїЅпїЅпїЅпїЅ"
http://www.rdw.ru
http://www.vashdosug.ru
Alexey V. Borzov writes:
Agh! I finally read up on module loading
http://developer.postgresql.org/docs/postgres/xfunc-c.html#XFUNC-C-DYNLOAD
and now I seem to understand. You see, the problem with the current
Makefile is as follows: it substitutes '$libdir' into both .sql and
perl files. While this is good enough for sql, $libdir is consumed
by Perl and thus perl scripts do NOT work.
Then fix the Perl scripts. Keep the bizarre code close to the cause, so
it's easier to maintain.
--
Peter Eisentraut peter_e@gmx.net