Win32 port

Started by Bruce Momjianabout 24 years ago38 messageshackers
Jump to latest
#1Hannu Krosing
hannu@tm.ee
In reply to: Bruce Momjian (#2)
Re: Win32 port

Bruce Momjian kirjutas K, 06.11.2002 kell 08:19:

I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
Win32, and SRA's port to Win32, and permission to generate a merged
patch that can be applied to 7.4.

Great!

Now that 7.3 is almost complete, I am going to start work on that. I
will post patches that deal with specific portability issues, like
fork/exec and path separator handling, and once reviewed, apply them to
the main CVS tree for 7.4.

What C compiler will you be working with ?

I hope that at least MingW should be supported ?

-------------
Hannu

#2Bruce Momjian
pgman@candle.pha.pa.us

I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
Win32, and SRA's port to Win32, and permission to generate a merged
patch that can be applied to 7.4.

Now that 7.3 is almost complete, I am going to start work on that. I
will post patches that deal with specific portability issues, like
fork/exec and path separator handling, and once reviewed, apply them to
the main CVS tree for 7.4.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#3Justin Clift
justin@postgresql.org
In reply to: Bruce Momjian (#2)
Re: Win32 port

Bruce Momjian wrote:

I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
Win32, and SRA's port to Win32, and permission to generate a merged
patch that can be applied to 7.4.

Now that 7.3 is almost complete, I am going to start work on that. I
will post patches that deal with specific portability issues, like
fork/exec and path separator handling, and once reviewed, apply them to
the main CVS tree for 7.4.

Whoo Hooo!

:-)

+ Justin

--
Bruce Momjian                        |  http://candle.pha.pa.us
pgman@candle.pha.pa.us               |  (610) 359-1001
+  If your life is a hard drive,     |  13 Roberts Road
+  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi

#4Matthew T. O'Connor
matthew@zeut.net
In reply to: Justin Clift (#3)
Re: Win32 port

On Wed, 2002-11-06 at 01:32, Justin Clift wrote:

Bruce Momjian wrote:

I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
Win32, and SRA's port to Win32, and permission to generate a merged
patch that can be applied to 7.4.

Now that 7.3 is almost complete, I am going to start work on that. I
will post patches that deal with specific portability issues, like
fork/exec and path separator handling, and once reviewed, apply them to
the main CVS tree for 7.4.

Whoo Hooo!

:-)

+ Justin

Couldn't agree with Justin more. Even though I won't use it in
production, We have developers that use postgres on their windows
laptops for development and cygwin just doesn't cut it.

#5Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Hannu Krosing (#1)
Re: Win32 port

Hannu Krosing wrote:

Bruce Momjian kirjutas K, 06.11.2002 kell 08:19:

I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
Win32, and SRA's port to Win32, and permission to generate a merged
patch that can be applied to 7.4.

Great!

Now that 7.3 is almost complete, I am going to start work on that. I
will post patches that deal with specific portability issues, like
fork/exec and path separator handling, and once reviewed, apply them to
the main CVS tree for 7.4.

What C compiler will you be working with ?

I hope that at least MingW should be supported ?

Actually, I will be doing all the coding on BSD/OS. I am more merging
patches than actual coding, though. This will guarantee that the
patches will not affect the Unix platforms. I will need help from
others to check the various Win32 compilers.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#6Jan Wieck
JanWieck@Yahoo.com
In reply to: Bruce Momjian (#5)
Re: Win32 port

Bruce Momjian wrote:

Hannu Krosing wrote:

Bruce Momjian kirjutas K, 06.11.2002 kell 08:19:

I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
Win32, and SRA's port to Win32, and permission to generate a merged
patch that can be applied to 7.4.

Great!

Now that 7.3 is almost complete, I am going to start work on that. I
will post patches that deal with specific portability issues, like
fork/exec and path separator handling, and once reviewed, apply them to
the main CVS tree for 7.4.

What C compiler will you be working with ?

I hope that at least MingW should be supported ?

Actually, I will be doing all the coding on BSD/OS. I am more merging
patches than actual coding, though. This will guarantee that the
patches will not affect the Unix platforms. I will need help from
others to check the various Win32 compilers.

I was wondering about that. How will you be able to verify that you got
a Win32 port that at least compiles, if you're merging two different
Win32 approaches into the code on BSD? I don't expect that to work at
all.

To Hannu: the Windows port we did here depends on MS VC++ features like
the ability to specify in the project to substitute header files. I
don't know much about MingW and if you can do things like that with it.
Our port is a real 100% pure Win32 one without any portability crap like
cygwin. I don't think that's a big problem, since the binary results of
a MS VC compile are redistributable AFAIK. And you'd need VC++ only if
you want to do backend development under Windows, and who want's that
(Katie for sure, but that's another story ;-P )

Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck@Yahoo.com #

#7Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Jan Wieck (#6)
Re: Win32 port

Jan Wieck wrote:

Actually, I will be doing all the coding on BSD/OS. I am more merging
patches than actual coding, though. This will guarantee that the
patches will not affect the Unix platforms. I will need help from
others to check the various Win32 compilers.

I was wondering about that. How will you be able to verify that you got
a Win32 port that at least compiles, if you're merging two different
Win32 approaches into the code on BSD? I don't expect that to work at
all.

It doesn't have to work on Win32 day 1. I will do all the work I can.
I will also be buying a machine that can compile this but right now I
want to get most of it in.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#8Joe Conway
mail@joeconway.com
In reply to: Bruce Momjian (#7)
Re: Win32 port

Bruce Momjian wrote:

Jan Wieck wrote:

Actually, I will be doing all the coding on BSD/OS. I am more merging
patches than actual coding, though. This will guarantee that the
patches will not affect the Unix platforms. I will need help from
others to check the various Win32 compilers.

I was wondering about that. How will you be able to verify that you got
a Win32 port that at least compiles, if you're merging two different
Win32 approaches into the code on BSD? I don't expect that to work at
all.

It doesn't have to work on Win32 day 1. I will do all the work I can.
I will also be buying a machine that can compile this but right now I
want to get most of it in.

Bruce, I can compile on VC++ (VS .Net) for you. Let me know when you're ready
with a patch.

Joe

#9Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Joe Conway (#8)
Re: Win32 port

Joe Conway wrote:

Bruce Momjian wrote:

Jan Wieck wrote:

Actually, I will be doing all the coding on BSD/OS. I am more merging
patches than actual coding, though. This will guarantee that the
patches will not affect the Unix platforms. I will need help from
others to check the various Win32 compilers.

I was wondering about that. How will you be able to verify that you got
a Win32 port that at least compiles, if you're merging two different
Win32 approaches into the code on BSD? I don't expect that to work at
all.

It doesn't have to work on Win32 day 1. I will do all the work I can.
I will also be buying a machine that can compile this but right now I
want to get most of it in.

Bruce, I can compile on VC++ (VS .Net) for you. Let me know when you're ready
with a patch.

Thanks. That will be a help. In fact, just running it through after I
make few commits should fix things up.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#10Peter Eisentraut
peter_e@gmx.net
In reply to: Jan Wieck (#6)
Re: Win32 port

Jan Wieck writes:

To Hannu: the Windows port we did here depends on MS VC++ features like
the ability to specify in the project to substitute header files. I
don't know much about MingW and if you can do things like that with it.

Before long someone will port the Windows port to MinGW, so we should
resist attempts to use compiler-specific features in the same way that we
tend not to use vendors specific features in other ports.

--
Peter Eisentraut peter_e@gmx.net

#11Justin Clift
justin@postgresql.org
In reply to: Peter Eisentraut (#10)
Re: Win32 port

Peter Eisentraut wrote:

Jan Wieck writes:

To Hannu: the Windows port we did here depends on MS VC++ features like
the ability to specify in the project to substitute header files. I
don't know much about MingW and if you can do things like that with it.

Before long someone will port the Windows port to MinGW, so we should
resist attempts to use compiler-specific features in the same way that we
tend not to use vendors specific features in other ports.

Absolutely. With the present push by over 30 governments of countries,
and other large institutions around the world for adopting Open Source
software in significant ways, we'd be kind of short-sighted to do things
in a way that mostly limits people to using M$ products.

:-)

Regards and best wishes,

Justin Clift

--
Peter Eisentraut peter_e@gmx.net

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi

#12Dave Page
dpage@vale-housing.co.uk
In reply to: Justin Clift (#11)
Re: Win32 port

-----Original Message-----
From: Joe Conway [mailto:mail@joeconway.com]
Sent: 06 November 2002 16:16
To: Bruce Momjian
Cc: Jan Wieck; Hannu Krosing; PostgreSQL-development; Tatsuo Ishii
Subject: Re: [HACKERS] Win32 port

Bruce, I can compile on VC++ (VS .Net) for you. Let me know
when you're ready
with a patch.

Joe

I can also help with VC++ 6, and .NET.

Regards, Dave.

#13Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Peter Eisentraut (#10)
Re: Win32 port

Peter Eisentraut wrote:

Jan Wieck writes:

To Hannu: the Windows port we did here depends on MS VC++ features like
the ability to specify in the project to substitute header files. I
don't know much about MingW and if you can do things like that with it.

Before long someone will port the Windows port to MinGW, so we should
resist attempts to use compiler-specific features in the same way that we
tend not to use vendors specific features in other ports.

Agreed. I will make as clean a patch as possible. I think it is
doable.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#14Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Jan Wieck (#6)
Re: Win32 port

Here is a list of patch areas that I will address with the Win32 port:

fork/exec
loop rename test
handle \r in COPY
copydir for cp -r
backslash tests
rmdir not recursive for rm -r
shared memory could map to new address in exec child
compatibility defines
file path separators
root directory
rename atomicity
spinlock changes
str[r]chr
timeval for psql
DWORD in help.c
initdb

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#15Jan Wieck
JanWieck@Yahoo.com
In reply to: Bruce Momjian (#13)
Re: Win32 port

Bruce Momjian wrote:

Peter Eisentraut wrote:

Jan Wieck writes:

To Hannu: the Windows port we did here depends on MS VC++ features like
the ability to specify in the project to substitute header files. I
don't know much about MingW and if you can do things like that with it.

Before long someone will port the Windows port to MinGW, so we should
resist attempts to use compiler-specific features in the same way that we
tend not to use vendors specific features in other ports.

Agreed. I will make as clean a patch as possible. I think it is
doable.

The thing with this particular feature was not to touch almost every
source file in the whole tree. The headers to #include in a clean Win32
world are totally different from what you #include in Unix.

Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck@Yahoo.com #

#16Jan Wieck
JanWieck@Yahoo.com
In reply to: Bruce Momjian (#14)
Re: Win32 port

Bruce Momjian wrote:

Here is a list of patch areas that I will address with the Win32 port:

fork/exec
loop rename test
handle \r in COPY
copydir for cp -r
backslash tests
rmdir not recursive for rm -r
shared memory could map to new address in exec child

That's actually not done in the port yet. Thomas once overhauled the
hashtable code and changed it from using offsets to pointers. This code
is used for shared hashtables, so the mapping has to be done at a fixed
address for now.

Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck@Yahoo.com #

#17Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Jan Wieck (#16)
Re: Win32 port

Jan Wieck wrote:

Bruce Momjian wrote:

Here is a list of patch areas that I will address with the Win32 port:

fork/exec
loop rename test
handle \r in COPY
copydir for cp -r
backslash tests
rmdir not recursive for rm -r
shared memory could map to new address in exec child

That's actually not done in the port yet. Thomas once overhauled the
hashtable code and changed it from using offsets to pointers. This code
is used for shared hashtables, so the mapping has to be done at a fixed
address for now.

OK, can we guarantee that fixed mapping will happen?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#18Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Jan Wieck (#15)
Re: Win32 port

Jan Wieck wrote:

Bruce Momjian wrote:

Peter Eisentraut wrote:

Jan Wieck writes:

To Hannu: the Windows port we did here depends on MS VC++ features like
the ability to specify in the project to substitute header files. I
don't know much about MingW and if you can do things like that with it.

Before long someone will port the Windows port to MinGW, so we should
resist attempts to use compiler-specific features in the same way that we
tend not to use vendors specific features in other ports.

Agreed. I will make as clean a patch as possible. I think it is
doable.

The thing with this particular feature was not to touch almost every
source file in the whole tree. The headers to #include in a clean Win32
world are totally different from what you #include in Unix.

OK, I am looking at the SRA patch and I don't see a huge number of
#include changes. Can you give an example? Also, isn't there a way to
do this in a more centralized way, perhaps in c.h?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#19Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Bruce Momjian (#18)
Re: Win32 port

Steve Howe wrote:

Hello Bruce,

Wednesday, November 6, 2002, 3:19:35 AM, you wrote:

BM> I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
BM> Win32, and SRA's port to Win32, and permission to generate a merged
BM> patch that can be applied to 7.4.

BM> Now that 7.3 is almost complete, I am going to start work on that. I
BM> will post patches that deal with specific portability issues, like
BM> fork/exec and path separator handling, and once reviewed, apply them to
BM> the main CVS tree for 7.4.
Just wondering, what compiler are they using ?
Will it compile using Mingw ?

I think the two projects are using MS C++, but it would be nice for
Mingw to work too.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#20Steve Howe
howe@carcass.dhs.org
In reply to: Bruce Momjian (#2)
Re: Win32 port

Hello Bruce,

Wednesday, November 6, 2002, 3:19:35 AM, you wrote:

BM> I have copies of Peer Direct's (Jan's company) port of PostgreSQL to
BM> Win32, and SRA's port to Win32, and permission to generate a merged
BM> patch that can be applied to 7.4.

BM> Now that 7.3 is almost complete, I am going to start work on that. I
BM> will post patches that deal with specific portability issues, like
BM> fork/exec and path separator handling, and once reviewed, apply them to
BM> the main CVS tree for 7.4.
Just wondering, what compiler are they using ?
Will it compile using Mingw ?

-------------
Best regards,
Steve Howe mailto:howe@carcass.dhs.org

#21Steve Howe
howe@carcass.dhs.org
In reply to: Bruce Momjian (#19)
#22Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Steve Howe (#21)
#23Alvaro Herrera
alvherre@dcc.uchile.cl
In reply to: Bruce Momjian (#22)
#24Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Alvaro Herrera (#23)
#25Neil Conway
neilc@samurai.com
In reply to: Bruce Momjian (#22)
#26Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Neil Conway (#25)
#27Justin Clift
justin@postgresql.org
In reply to: Bruce Momjian (#26)
#28Tom Lane
tgl@sss.pgh.pa.us
In reply to: Justin Clift (#27)
#29Steve Howe
howe@carcass.dhs.org
In reply to: Bruce Momjian (#26)
#30Katie Ward
kward@peerdirect.com
In reply to: Bruce Momjian (#22)
#31Katie Ward
kward@peerdirect.com
In reply to: Bruce Momjian (#22)
#32Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Katie Ward (#31)
#33Steve Howe
howe@carcass.dhs.org
In reply to: Katie Ward (#31)
#34Dave Page
dpage@vale-housing.co.uk
In reply to: Steve Howe (#33)
#35Katie Ward
kward@peerdirect.com
In reply to: Steve Howe (#33)
#36Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Dave Page (#34)
#37Dave Page
dpage@vale-housing.co.uk
In reply to: Bruce Momjian (#36)
#38Peter Eisentraut
peter_e@gmx.net
In reply to: Bruce Momjian (#32)