Re: pg_waldump: support decoding of WAL inside tarfile

Started by Andrew Dunstan19 days ago2 messageshackers
Jump to latest
#1Andrew Dunstan
andrew@dunslane.net

On Mar 28, 2026, at 7:34 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Thomas Munro <thomas.munro@gmail.com> writes:

On Sun, Mar 29, 2026 at 11:37 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
It looks like to make this test stable on modern FreeBSD,
we need to see if tar accepts --no-read-sparse and use that
switch if so.

Yeah. Here's my attempt at perl.

Andrew might have some stylistic suggestions, but this looks
plausible to me.

Looks basically ok to me, although I wouldn’t make the variable name all caps.

Cheers

Andrew

#2Thomas Munro
thomas.munro@gmail.com
In reply to: Andrew Dunstan (#1)

On Sun, Mar 29, 2026 at 2:59 PM Andrew Dunstan <andrew@dunslane.net> wrote:

Looks basically ok to me, although I wouldn’t make the variable name all caps.

Will fix and push. Thanks!