Minor cleanup of Meson files given that we require 0.57
Hi,
I found a couple of comments about features not supported in meson
versions previous to 0.57 but since we know do require 0.57.2 we can
safely fix them.
The issue fixed is that check_header() previously did not support
dependencies declared with declare_dependency() which seems like an easy
fix which improves code quality a bit.
I also found a comment with a typo which claimed a feature requires
0.56, but str.replace() actually requires 0.58.
--
Andreas Karlsson
Percona
Attachments:
v1-0001-Meson-Fix-todos-about-check_header-with-virtual-d.patchtext/x-patch; charset=UTF-8; name=v1-0001-Meson-Fix-todos-about-check_header-with-virtual-d.patchDownload+14-23
v1-0002-Meson-Fix-version-number-in-todo-comment-about-st.patchtext/x-patch; charset=UTF-8; name=v1-0002-Meson-Fix-version-number-in-todo-comment-about-st.patchDownload+1-2
Both patches look good to me!
--
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)
On Wed, Apr 15, 2026 at 09:33:41PM +0000, Tristan Partin wrote:
Both patches look good to me!
I have skimmed through the patches quickly, and they sound rather
correct (need to double-check in depth). Anyway, asking before doing
anything.. Would there be any objections to this simplification on
HEAD, now that we require 0.57.2?
--
Michael