pgsql: Handle carriage returns and line feeds in COPY CSV mode.

Started by Bruce Momjianover 21 years ago7 messagescomitters

bruce@momjian.us

over 21 years ago

Log Message:
-----------
Handle carriage returns and line feeds in COPY CSV mode.

Andrew Dunstan

Modified Files:
--------------
pgsql/src/backend/commands:
copy.c (r1.236 -> r1.237)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/copy.c.diff?r1=1.236&r2=1.237)

Neil Conway

neilc@samurai.com

over 21 years ago

In reply to: Bruce Momjian (#1)

Re: pgsql: Handle carriage returns and line feeds in

Bruce Momjian wrote:

Handle carriage returns and line feeds in COPY CSV mode.

Would it be possible to have some regression tests for this?

-Neil

Bruce Momjian

bruce@momjian.us

over 21 years ago

In reply to: Neil Conway (#2)

Re: pgsql: Handle carriage returns and line feeds in COPY

Neil Conway wrote:

Bruce Momjian wrote:

Handle carriage returns and line feeds in COPY CSV mode.

Would it be possible to have some regression tests for this?

Yep, Andrew?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Andrew Dunstan

andrew@dunslane.net

over 21 years ago

In reply to: Bruce Momjian (#3)

Re: pgsql: Handle carriage returns and line feeds in COPY

Bruce Momjian said:

Neil Conway wrote:

Bruce Momjian wrote:

Handle carriage returns and line feeds in COPY CSV mode.

Would it be possible to have some regression tests for this?

Yep, Andrew?

Sure. I'll turn my test script into a regression test.

cheers]

andrew

Andrew Dunstan

andrew@dunslane.net

over 21 years ago

In reply to: Neil Conway (#2)

Re: [COMMITTERS] pgsql: Handle carriage returns and line feeds in

Neil Conway wrote:

Bruce Momjian wrote:

Handle carriage returns and line feeds in COPY CSV mode.

Would it be possible to have some regression tests for this?

will this do?

cheers

andrew

Bruce Momjian

bruce@momjian.us

over 21 years ago

In reply to: Andrew Dunstan (#5)

Re: [COMMITTERS] pgsql: Handle carriage returns and line feeds in COPY

Beautiful.

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------

Andrew Dunstan wrote:

Neil Conway wrote:

Bruce Momjian wrote:

Handle carriage returns and line feeds in COPY CSV mode.

Would it be possible to have some regression tests for this?

will this do?

cheers

andrew

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Bruce Momjian

bruce@momjian.us

over 21 years ago

In reply to: Andrew Dunstan (#5)

Re: [COMMITTERS] pgsql: Handle carriage returns and line feeds in COPY

Patch applied. Thanks.

---------------------------------------------------------------------------

Andrew Dunstan wrote:

Neil Conway wrote:

Bruce Momjian wrote:

Handle carriage returns and line feeds in COPY CSV mode.

Would it be possible to have some regression tests for this?

will this do?

cheers

andrew

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql: Handle carriage returns and line feeds in COPY CSV mode.

Attachments: