drop database if exists

here's a patch for "drop database if exists". Barring objections I will
apply it in a day or two.

Should we use the IF EXISTS syntax in pg_dump output? For all DROP
commands in clean mode?

Might make it easier to wrap pg_dump output in a transaction?

Chris

Andrew Dunstan <andrew@dunslane.net> writes:

here's a patch for "drop database if exists". Barring objections I will
apply it in a day or two.

Please try to remember the src/backend/nodes/ files this time.

(In general, when modifying a widely-known struct such as a parse node
type, it's a good idea to grep for every single mention of the struct
type to make sure you've not missed anything.)

regards, tom lane

Tom Lane wrote:

Andrew Dunstan <andrew@dunslane.net> writes:

here's a patch for "drop database if exists". Barring objections I will
apply it in a day or two.

Please try to remember the src/backend/nodes/ files this time.

(In general, when modifying a widely-known struct such as a parse node
type, it's a good idea to grep for every single mention of the struct
type to make sure you've not missed anything.)

oops, ok, thanks, will do. Should we perhaps add a note to parsenodes.h ?

cheers

andrew

Andrew Dunstan <andrew@dunslane.net> writes:

Tom Lane wrote:

(In general, when modifying a widely-known struct such as a parse node
type, it's a good idea to grep for every single mention of the struct
type to make sure you've not missed anything.)

oops, ok, thanks, will do. Should we perhaps add a note to parsenodes.h ?

[ shrug... ] There are a whole lot of header files that would need such
a note, and I suspect people wouldn't read it anyway :-(

regards, tom lane

Christopher Kings-Lynne wrote:

here's a patch for "drop database if exists". Barring objections I will
apply it in a day or two.

Should we use the IF EXISTS syntax in pg_dump output? For all DROP
commands in clean mode?

Yes, I was thinking it should be used for pg_dump --clean, which is a
TODO item. I was also thinking the DROP OWNER could be used for
--clean:

o Allow pg_dump --clean to drop roles that own objects or have
privileges

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073