pgsql: Make integer_datetimes the default on msvc as well, to have the

Started by Magnus Haganderabout 18 years ago3 messagescomitters
Jump to latest
#1Magnus Hagander
magnus@hagander.net

Log Message:
-----------
Make integer_datetimes the default on msvc as well, to have the same
default as other platforms.

Modified Files:
--------------
pgsql/src/tools/msvc:
config.pl (r1.9 -> r1.10)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/msvc/config.pl?r1=1.9&r2=1.10)

#2Andrew Dunstan
andrew@dunslane.net
In reply to: Magnus Hagander (#1)
Re: pgsql: Make integer_datetimes the default on msvc as well, to have the

Magnus Hagander wrote:

Log Message:
-----------
Make integer_datetimes the default on msvc as well, to have the same
default as other platforms.

Modified Files:
--------------
pgsql/src/tools/msvc:
config.pl (r1.9 -> r1.10)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/msvc/config.pl?r1=1.9&r2=1.10)

I don't actually think this is the right way to do this. It's not the
same thing. The equivalent behaviour would be to have the flag turned on
even if there's nothing in the config file. What I think we need is to
add this line in Solution.pm::new():

$options->{integer_datetimes} = 1 unless exists
$config->{integer_datetimes};

That way we turn the flag on if the config says nothing at all, but if
it says anything we respect what it says.

cheers

andrew

#3Andrew Dunstan
andrew@dunslane.net
In reply to: Andrew Dunstan (#2)
Re: pgsql: Make integer_datetimes the default on msvc as well, to have the

I wrote:

I don't actually think this is the right way to do this. It's not the
same thing. The equivalent behaviour would be to have the flag turned
on even if there's nothing in the config file. What I think we need is
to add this line in Solution.pm::new():

$options->{integer_datetimes} = 1 unless exists
$config->{integer_datetimes};

s/config/options/ , of course

cheers

andrew