pgsql: Applied Zoltan's patch to remove hardware dependant offset

Started by Michael Meskesover 16 years ago3 messagescomitters
Jump to latest
#1Michael Meskes
meskes@postgresql.org

Log Message:
-----------
Applied Zoltan's patch to remove hardware dependant offset logging and
superfluous include files.

Modified Files:
--------------
pgsql/src/interfaces/ecpg/ecpglib:
sqlda.c (r1.1 -> r1.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/ecpglib/sqlda.c?r1=1.1&r2=1.2)
pgsql/src/interfaces/ecpg/test/expected:
compat_informix-sqlda.stderr (r1.1 -> r1.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.stderr?r1=1.1&r2=1.2)
sql-sqlda.stderr (r1.1 -> r1.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/expected/sql-sqlda.stderr?r1=1.1&r2=1.2)

#2Andrew Dunstan
andrew@dunslane.net
In reply to: Michael Meskes (#1)
Re: pgsql: Applied Zoltan's patch to remove hardware dependant offset

This patch still leaves in some uses of __FUNCTION__ which is breaking
non-gcc compilers: see for example
<http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gypsy_moth&amp;dt=2010-01-06%2013:50:01&gt;

elog.h defines PG_FUNCNAME_MACRO which you should use instead.

cheers

andrew

Michael Meskes wrote:

Show quoted text

Log Message:
-----------
Applied Zoltan's patch to remove hardware dependant offset logging and
superfluous include files.

Modified Files:
--------------
pgsql/src/interfaces/ecpg/ecpglib:
sqlda.c (r1.1 -> r1.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/ecpglib/sqlda.c?r1=1.1&amp;r2=1.2)
pgsql/src/interfaces/ecpg/test/expected:
compat_informix-sqlda.stderr (r1.1 -> r1.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.stderr?r1=1.1&amp;r2=1.2)
sql-sqlda.stderr (r1.1 -> r1.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/expected/sql-sqlda.stderr?r1=1.1&amp;r2=1.2)

#3Andrew Dunstan
andrew@dunslane.net
In reply to: Michael Meskes (#1)
Re: pgsql: Applied Zoltan's patch to remove hardware dependant offset

We are also breaking Windows by using int64_t. See
<http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=red_bat&amp;dt=2010-01-06%2011:30:03&gt;

You could possibly use int64, which is defined in c.h.

cheers

andrew

Michael Meskes wrote:

Show quoted text

Log Message:
-----------
Applied Zoltan's patch to remove hardware dependant offset logging and
superfluous include files.

Modified Files:
--------------
pgsql/src/interfaces/ecpg/ecpglib:
sqlda.c (r1.1 -> r1.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/ecpglib/sqlda.c?r1=1.1&amp;r2=1.2)
pgsql/src/interfaces/ecpg/test/expected:
compat_informix-sqlda.stderr (r1.1 -> r1.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.stderr?r1=1.1&amp;r2=1.2)
sql-sqlda.stderr (r1.1 -> r1.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/expected/sql-sqlda.stderr?r1=1.1&amp;r2=1.2)