pgsql: Mention why one C file fails pgindent.
Log Message:
-----------
Mention why one C file fails pgindent.
Modified Files:
--------------
pgsql/src/tools/pgindent:
README (r1.41 -> r1.42)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/pgindent/README?r1=1.41&r2=1.42)
Bruce Momjian wrote:
Log Message:
-----------
Mention why one C file fails pgindent.Modified Files:
--------------
pgsql/src/tools/pgindent:
README (r1.41 -> r1.42)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/pgindent/README?r1=1.41&r2=1.42)
Why not add the file that breaks to
src/tools/pgindent/exclude_file_patterns? (And also maybe the file Tom
just fixed).
And ISTM we should have a list of typdefs for pgindent to ignore anyway.
Currently, the buildfarm ignores:
'date','interval','timestamp','ANY'
We should probably add 'DECIMAL' to that list.
But really, this list should probably be part of pgindent, not of the
typedef finding code.
cheers
andrew
Andrew Dunstan wrote:
Bruce Momjian wrote:
Log Message:
-----------
Mention why one C file fails pgindent.Modified Files:
--------------
pgsql/src/tools/pgindent:
README (r1.41 -> r1.42)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/pgindent/README?r1=1.41&r2=1.42)
[ Sorry for the late reply.]
Why not add the file that breaks to
src/tools/pgindent/exclude_file_patterns? (And also maybe the file Tom
just fixed).
I thought about that, but right now exclude_file_patterns only has files
who's contents by definition can't be handled by pgindent, or we don't
want to be handled by pgindent. wparser_def.c is a case where it is a
specific macro that is triggering the problem.
And ISTM we should have a list of typdefs for pgindent to ignore anyway.
Currently, the buildfarm ignores:'date','interval','timestamp','ANY'
We should probably add 'DECIMAL' to that list.
Yes, we could do that, but looking now, I see that several macros
already use _T to prevent name conflicts, so I have done that with
DECIMAL, now DECIMAL_T; patch attached.
But really, this list should probably be part of pgindent, not of the
typedef finding code.
Hard to say on that one. I can easily add a filter file; I should also
rewrite it in perl and try out GUN indent too, but I have no idea what
day that will be. :-(
Thanks for the ideas.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +