pgsql: Fix background workers for EXEC_BACKEND

Started by Alvaro Herreraover 13 years ago3 messagescomitters
Jump to latest
#1Alvaro Herrera
alvherre@2ndquadrant.com

Fix background workers for EXEC_BACKEND

Commit da07a1e8 was broken for EXEC_BACKEND because I failed to realize
that the MaxBackends recomputation needed to be duplicated by
subprocesses in SubPostmasterMain. However, instead of having the value
be recomputed at all, it's better to assign the correct value at
postmaster initialization time, and have it be propagated to exec'ed
backends via BackendParameters.

MaxBackends stays as zero until after modules in
shared_preload_libraries have had a chance to register bgworkers, since
the value is going to be untrustworthy till that's finished.

Heikki Linnakangas and Álvaro Herrera

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cdbc0ca48ca96e5c787b1605ed2d6cf7407a5acf

Modified Files
--------------
src/backend/postmaster/postmaster.c | 44 ++++++++++++++++++++++++++++------
src/backend/utils/init/globals.c | 9 ++++---
src/backend/utils/misc/guc.c | 30 +----------------------
src/include/postmaster/postmaster.h | 9 +++++++
4 files changed, 52 insertions(+), 40 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Andrew Dunstan
andrew@dunslane.net
In reply to: Alvaro Herrera (#1)
Re: pgsql: Fix background workers for EXEC_BACKEND

On 01/02/2013 10:32 AM, Alvaro Herrera wrote:

Fix background workers for EXEC_BACKEND

Apparently not so much. It's caused serious buildfarm breakage.

cheers

andrew

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Andrew Dunstan (#2)
Re: pgsql: Fix background workers for EXEC_BACKEND

Andrew Dunstan wrote:

On 01/02/2013 10:32 AM, Alvaro Herrera wrote:

Fix background workers for EXEC_BACKEND

Apparently not so much. It's caused serious buildfarm breakage.

Yeah, I noticed. I'm on it.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers