pgsql: doc: improve wording of COPY commit 7ec73783d88a743799b0c262f12

Started by Bruce Momjianabout 12 years ago3 messagescomitters
Jump to latest
#1Bruce Momjian
bruce@momjian.us

doc: improve wording of COPY commit 7ec73783d88a743799b0c262f1235f772497fb1d

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9970443640b4569cf72b3c8e84abe80bdf533c7f

Modified Files
--------------
doc/src/sgml/ref/copy.sgml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Andrew Dunstan
andrew@dunslane.net
In reply to: Bruce Momjian (#1)
Re: pgsql: doc: improve wording of COPY commit 7ec73783d88a743799b0c262f12

On 04/22/2014 07:16 PM, Bruce Momjian wrote:

doc: improve wording of COPY commit 7ec73783d88a743799b0c262f1235f772497fb1d

This isn't an improvement: it's made it incorrect. The null string is
not necessarily empty, it is only empty by default. People keep making
this mistake (and indeed, the original patch made the same mistake in
its code, which I corrected), probably because specifyng anything other
than the empty string is unusual. However, snice we have made provision
for it not to be empty we should describe it accurately.

cheers

andrew

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Bruce Momjian
bruce@momjian.us
In reply to: Andrew Dunstan (#2)
Re: pgsql: doc: improve wording of COPY commit 7ec73783d88a743799b0c262f12

On Tue, Apr 22, 2014 at 07:55:56PM -0400, Andrew Dunstan wrote:

On 04/22/2014 07:16 PM, Bruce Momjian wrote:

doc: improve wording of COPY commit 7ec73783d88a743799b0c262f1235f772497fb1d

This isn't an improvement: it's made it incorrect. The null string
is not necessarily empty, it is only empty by default. People keep
making this mistake (and indeed, the original patch made the same
mistake in its code, which I corrected), probably because specifyng
anything other than the empty string is unusual. However, snice we
have made provision for it not to be empty we should describe it
accurately.

Sorry, fixed. Thanks.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers