pgsql: postgres_fdw: Attempt to stabilize regression results.

Started by Robert Haasover 9 years ago2 messagescomitters
Jump to latest
#1Robert Haas
robertmhaas@gmail.com

postgres_fdw: Attempt to stabilize regression results.

Set enable_hashagg to false for tests involving least_agg(), so that
we get the same plan regardless of local costing variances. Also,
remove a test involving sqrt(); it's there to test deparsing of
HAVING clauses containing expressions, but that's tested elsewhere
anyway, and sqrt(2) deparses with different amounts of precision on
different machines.

Per buildfarm.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ad13a09d762f0c903a52ed0ec668a0ba51a61047

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 74 ++++++++------------------
contrib/postgres_fdw/sql/postgres_fdw.sql | 9 ++--
2 files changed, 25 insertions(+), 58 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Andrew Dunstan
andrew@dunslane.net
In reply to: Robert Haas (#1)
Re: pgsql: postgres_fdw: Attempt to stabilize regression results.

On 10/21/2016 11:33 AM, Robert Haas wrote:

postgres_fdw: Attempt to stabilize regression results.

Set enable_hashagg to false for tests involving least_agg(), so that
we get the same plan regardless of local costing variances. Also,
remove a test involving sqrt(); it's there to test deparsing of
HAVING clauses containing expressions, but that's tested elsewhere
anyway, and sqrt(2) deparses with different amounts of precision on
different machines.

Looks like brolga still has issues with this.

cheers

andrew

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers