Integer datetime by default

Started by Neil Conwayabout 18 years ago6 messageshackers
Jump to latest
#1Neil Conway
neilc@samurai.com

Attached is a refreshed patch that makes integer datetimes the default.
Platforms that don't have a working 64-bit integer type will fail to
configure by default; they can specify "--disable-integer-datetimes" to
switch back to using floating-point based datetimes.

Barring any objections, I'll apply this to HEAD tomorrow.

-Neil

Attachments:

integer_datetime_default-3.patchtext/x-patch; charset=UTF-8; name=integer_datetime_default-3.patchDownload+116-82
#2Neil Conway
neilc@samurai.com
In reply to: Neil Conway (#1)
Re: Integer datetime by default

On Tue, 2008-03-25 at 12:54 -0700, Neil Conway wrote:

Barring any objections, I'll apply this to HEAD tomorrow.

Applied to HEAD.

-Neil

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Neil Conway (#2)
Re: [PATCHES] Integer datetime by default

Neil Conway <neilc@samurai.com> writes:

Applied to HEAD.

At this point it would probably be a good idea if a couple of buildfarm
machines were to start testing builds with --disable-integer-datetimes
... any volunteers out there?

regards, tom lane

#4Andrew Dunstan
andrew@dunslane.net
In reply to: Tom Lane (#3)
Re: [PATCHES] Integer datetime by default

Tom Lane wrote:

Neil Conway <neilc@samurai.com> writes:

Applied to HEAD.

At this point it would probably be a good idea if a couple of buildfarm
machines were to start testing builds with --disable-integer-datetimes
... any volunteers out there?

I have changed the dashboard page to reflect the new default. I believe
one or two people are going to change their configs.

I'm not sure what we do about this in MSVC config - I will explore.

cheers

andrew

#5Magnus Hagander
magnus@hagander.net
In reply to: Andrew Dunstan (#4)
Re: [PATCHES] Integer datetime by default

Andrew Dunstan wrote:

Tom Lane wrote:

Neil Conway <neilc@samurai.com> writes:

Applied to HEAD.

At this point it would probably be a good idea if a couple of
buildfarm machines were to start testing builds with
--disable-integer-datetimes ... any volunteers out there?

I have changed the dashboard page to reflect the new default. I
believe one or two people are going to change their configs.

I'm not sure what we do about this in MSVC config - I will explore.

You mean how to make it the default? config.pl needs to be changed.
Which should've been done when it was changed in configure, but wasn't
- I will go ahead and fix that right away.

//Magnus

#6Guillaume Smet
guillaume.smet@gmail.com
In reply to: Tom Lane (#3)
Re: [PATCHES] Integer datetime by default

On Sun, Mar 30, 2008 at 6:29 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Neil Conway <neilc@samurai.com> writes:

Applied to HEAD.

At this point it would probably be a good idea if a couple of buildfarm
machines were to start testing builds with --disable-integer-datetimes
... any volunteers out there?

I set up a new animal called marten with --disable-integer-datetimes.

http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=marten&amp;dt=2008-04-09%2020:45:22

--
Guillaume