get rid of psql welcome message

Peter Eisentraut wrote:

Around
<http://archives.postgresql.org/pgsql-patches/2008-01/msg00089.php&gt;
it was proposed to truncate the psql welcome screen. What do you
think about that?

Personally, I'd get rid of it all, because it gets boring after about
three uses, so that we would be at

If we have readline installed, we could perhaps have it show the first
time you launch psql, but if there is a .psql_history file around,
don't show it?

peter@colt:~$ psql testdb
testdb=#

The version mismatch warning would remain, of course.

I'd also like to get rid of the SSL notice but I'm not sure what to
replace it by. Something in the prompt perhaps?

That would work. It just has to keep being possible to quickly see if
a connection is secured.

//Magnus

Peter Eisentraut wrote:

Around <http://archives.postgresql.org/pgsql-patches/2008-01/msg00089.php&gt; it
was proposed to truncate the psql welcome screen. What do you think about
that?

Personally, I'd get rid of it all, because it gets boring after about three
uses, so that we would be at

peter@colt:~$ psql testdb
testdb=#

The version mismatch warning would remain, of course.

I'd also like to get rid of the SSL notice but I'm not sure what to replace it
by. Something in the prompt perhaps?

Btw., any user could put the welcome message in his own psqlrc file via \echo
commands in case they are really attached to it.

If you do this, adding psql internal variables so a prompt could be
built would be a nice way to go. For a default, perhaps nothing special
at all to flag the connection as ssl? If it matters to someone, they can
always set their prompt default to include this, set pgsslmode
appropriately, or call ensure sslinfo is installed and use it.

Is it worth promoting sslinfo into the core and adding a few new
functions to expose at least the same information (cypher, etc)? While
this isn't strictly related to what you're up to, sslinfo is a very nice
complement for arbitrary programs to confirm they are talking ssl.

From woehrer at par.univie.ac.at Thu Apr 17 13:22:47 2008
From: woehrer at par.univie.ac.at (=?ISO-8859-1?Q?Alexander_W=F6hrer?=)
Date: Thu, 17 Apr 2008 15:22:47 +0200
Subject: [Pljava-dev] stack depth limit exceeded - patch possible?
In-Reply-To: <4806264F.1060800@ejurka.com>
References: <48010499.30000@par.univie.ac.at>
<Pine.BSO.4.64.0804131023000.9928@leary.csoft.net>
<58782.88.116.137.78.1208177811.squirrel@www.par.univie.ac.at>
<Pine.BSO.4.64.0804141112330.5378@leary.csoft.net>
<48060EE6.9040009@par.univie.ac.at> <4806264F.1060800@ejurka.com>
Message-ID: <48074F27.9050606@par.univie.ac.at>

Dear Kris,

first of all thank you very much for your fast response including a
patch suggestion for my issue.
I made the changes to the 2 pljava source files (one c File, one java
File changed) as proposed by you, assuming that

*** 153,159 ****
{
synchronized(Backend.THREADLOCK)
{
! return _move(m_pointer, forward, count);
}
}

--- 153,159 ----
  	{
  		synchronized(Backend.THREADLOCK)
  		{
! 			return _fetch(m_pointer, System.identityHashCode(Thread.currentThread()), forward, count);
  		}
  	}

***************

should be changed to the new return _move(.....) as well as done for the return _fetch(...).

As I never built postgresql nor pljava local on my Win XP maschine I installed mingw and msys, set msys\bin in my path and tried to build the pl/java release with

make release

from the root directory of the pljava src distribution (/e/downloads/pljava).

Then I get the following error:
make[1]: Entering directory `/e/downloads/pljava-1.4.0/build/classes/pljava'
javac -source 1.4 -target 1.4 -d . <java sources>
javac: no source files
make[1]: *** [.timestamp] Error 2
make[1]: Leaving directory `/e/downloads/pljava-1.4.0/build/classes/pljava'
make: *** [pljava_all] Error 2

What else do I have to set in order to get the built process working?

Regards,

Alexander

Kris Jurka schrieb:

Alexander W?hrer wrote:

2304DEBUG: Changed stack_base_ptr from 00BDFC9A to 0B1EFAF4
2304DEBUG: Restored stack_base_ptr to 00BDFC9A
2304DEBUG: Changed stack_base_ptr from 00BDFC9A to 0B1EFAC8
2304DEBUG: Restored stack_base_ptr to 00BDFC9A
2304DEBUG: Exception in function SPI_cursor_fetch
org.postgresql.pljava.internal.ServerException: stack depth limit
exceeded
at org.postgresql.pljava.internal.Portal._fetch(Native Method)
at org.postgresql.pljava.internal.Portal.fetch(Portal.java:91)

So you can see the initial stack_base_ptr being adjusted when the
query is initially executed. Unfortunately pljava is not adjusting it
again later when rs.next() is being called. So if the portal fetch
needs to do any actual work (that is the results were not materialized
by the initial execution) it needs to adjust the stack as well. Can
you try the attached patch to see if it fixes things for you?

In general it seems that anything operating inside of
synchronized(Backend.THREADLOCK) might need to adjust the stack unless
it's certain the work it's doing is trivial and won't invoke
check_stack_depth. Unfortunately I don't know enough about when pg
calls check_stack_depth to know offhand what is/is not safe. A more
thorough audit is required here. Let's start with this patch and see
where that gets us.

Kris Jurka

--
**********************************************
University of Vienna
Institute for Scientific Computing
Nordbergstra?e 15/C/311
A-1090 Vienna
Austria

tel.: +43-1-4277-39421
fax.: +43-1-4277-9394
e-mail: woehrer at par.univie.ac.at
url: http://www.par.univie.ac.at/~woehrer/
**********************************************

On Thu, 2008-04-17 at 14:39 +0200, Peter Eisentraut wrote:

Personally, I'd get rid of it all, because it gets boring after about three
uses, so that we would be at

Many people I speak to use Postgres every 6 months or so, so changes
like this make them think its broke when its not.

I'd vote No, because personally I find software that changes for no good
reason to be boring, potentially bug causing and requires many
screenshots and HOWTOs of the software to become outdated.

I do strongly support your efforts to improve usability though but let's
keep stuff that works the same.

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com

* Peter Eisentraut (peter_e@gmx.net) wrote:

Around <http://archives.postgresql.org/pgsql-patches/2008-01/msg00089.php&gt; it
was proposed to truncate the psql welcome screen. What do you think about
that?

I'd recommend an option in .psqlrc to disable it, if possible. That
would be in line with what alot of other "splash-screen" type things do.

Thanks,

Stephen

Am I missing something..

$ psql -q testdb
testdb=#

And - if you're using bash - you could just

$ alias "psql=psql -q"
$ psql testdb
testdb=#

On Thursday 17 April 2008 13:39:43 Peter Eisentraut wrote:

Around <http://archives.postgresql.org/pgsql-patches/2008-01/msg00089.php&gt;
it was proposed to truncate the psql welcome screen. What do you think
about that?

Personally, I'd get rid of it all, because it gets boring after about three
uses, so that we would be at

peter@colt:~$ psql testdb
testdb=#

The version mismatch warning would remain, of course.

I'd also like to get rid of the SSL notice but I'm not sure what to replace
it by. Something in the prompt perhaps?

Btw., any user could put the welcome message in his own psqlrc file via
\echo commands in case they are really attached to it.

--
Mike Aubury

Aubit Computing Ltd is registered in England and Wales, Number: 3112827
Registered Address : Clayton House,59 Piccadilly,Manchester,M1 2AQ

am Thu, dem 17.04.2008, um 14:39:43 +0200 mailte Peter Eisentraut folgendes:

Around <http://archives.postgresql.org/pgsql-patches/2008-01/msg00089.php&gt; it
was proposed to truncate the psql welcome screen. What do you think about
that?

Personally, I'd get rid of it all, because it gets boring after about three
uses, so that we would be at

peter@colt:~$ psql testdb
testdb=#

I'd vote No, because i see very often on #irc people asking something
like 'how can i see the table definition' or other, and in this cases
it's easy to say: hey dude, read the fine welcome message *g*

Okay, maybe a new switch on the command-line or a .psqlrc-parameter to
suppress this message...

Regards, Andreas
--
Andreas Kretschmer
Kontakt: Heynitz: 035242/47150, D1: 0160/7141639 (mehr: -> Header)
GnuPG-ID: 0x3FFF606C, privat 0x7F4584DA http://wwwkeys.de.pgp.net

Mike Aubury wrote:

Am I missing something..

$ psql -q testdb
testdb=#

This also quiets out a few other unrelated things.

A. Kretschmer wrote:

I'd vote No, because i see very often on #irc people asking something
like 'how can i see the table definition' or other, and in this cases
it's easy to say: hey dude, read the fine welcome message *g*

I take this as evidence that the welcome message has limited use in practice.
The recently added "help" command will probably be (minimally) more suited to
these kinds of people.

On Thu, 2008-04-17 at 09:30 -0400, Stephen Frost wrote:

* Peter Eisentraut (peter_e@gmx.net) wrote:

Around <http://archives.postgresql.org/pgsql-patches/2008-01/msg00089.php&gt; it
was proposed to truncate the psql welcome screen. What do you think about
that?

I'd recommend an option in .psqlrc to disable it, if possible. That
would be in line with what alot of other "splash-screen" type things do.

+1

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com

Peter Eisentraut <peter_e@gmx.net> writes:

Around <http://archives.postgresql.org/pgsql-patches/2008-01/msg00089.php&gt; it
was proposed to truncate the psql welcome screen. What do you think about
that?

Personally. I'm very seriously against losing the version number banner.
I could do without any of the rest of it.

regards, tom lane

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, Apr 18, 2008 at 12:36 AM, Tom Lane wrote:

Peter Eisentraut writes:

Around it
was proposed to truncate the psql welcome screen. What do you think about
that?

Personally. I'm very seriously against losing the version number banner.
I could do without any of the rest of it.

+1 for keeping the version number up there.

Cheers,
BJ
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: http://getfiregpg.org

iD8DBQFIB2Mx5YBsbHkuyV0RAjhZAJ9wCS4EjQOGb5sJPJLC0yd/CtSWRgCeJ/pi
cQ1qMGtQjsDo7IOiKvPfUNU=
=W8uL
-----END PGP SIGNATURE-----

Brendan Jurd wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, Apr 18, 2008 at 12:36 AM, Tom Lane wrote:

Peter Eisentraut writes:

Around it
was proposed to truncate the psql welcome screen. What do you think about
that?

Personally. I'm very seriously against losing the version number banner.
I could do without any of the rest of it.

+1 for keeping the version number up there.

A prompt escape for the version would actually be nice.

cheers

andrew

On Thu, 17 Apr 2008 11:11:58 -0400
Andrew Dunstan <andrew@dunslane.net> wrote:

Brendan Jurd wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, Apr 18, 2008 at 12:36 AM, Tom Lane wrote:

Peter Eisentraut writes:

Around it
was proposed to truncate the psql welcome screen. What do you
think about that?

Personally. I'm very seriously against losing the version number
banner. I could do without any of the rest of it.

Currently our prompt is fairly verbose:

Welcome to psql 8.1.10, the PostgreSQL interactive terminal.

Type: \copyright for distribution terms
\h for help with SQL commands
\? for help with psql commands
\g or terminate with semicolon to execute query
\q to quit

We could just do:

psql 8.1.10 - postgresql server version 8.1.10

Type: \h for SQL help, \? for psql help, \q to quit

postgres=#

--
The PostgreSQL Company since 1997: http://www.commandprompt.com/
PostgreSQL Community Conference: http://www.postgresqlconference.org/
Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate
PostgreSQL SPI Liaison | SPI Director | PostgreSQL political pundit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

We could just do:

psql 8.1.10 - postgresql server version 8.1.10

Type: \h for SQL help, \? for psql help, \q to quit

Best idea yet. I also still like the .psqlrc no-splash
option, no reason we can't do both.

- --
Greg Sabino Mullane greg@turnstep.com
End Point Corporation
PGP Key: 0x14964AC8 200804171238
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----

iEYEAREDAAYFAkgHfOwACgkQvJuQZxSWSsiqVgCgmICB56XnU0+fuPiAblPmYJmU
CcsAoL4T+3hh3wA04nzrrt3R2ioQeJ69
=YTw/
-----END PGP SIGNATURE-----

Simon Riggs wrote:

On Thu, 2008-04-17 at 09:30 -0400, Stephen Frost wrote:

* Peter Eisentraut (peter_e@gmx.net) wrote:

Around <http://archives.postgresql.org/pgsql-patches/2008-01/msg00089.php&gt; it
was proposed to truncate the psql welcome screen. What do you think about
that?

I'd recommend an option in .psqlrc to disable it, if possible. That
would be in line with what alot of other "splash-screen" type things do.

+1

+1

I honestly don't care that I get a few lines of garbage as I start psql
- I never really look at it myself (the first dozen times I used pg it
was probably helpful to have the help commands there).
So what if you get a few lines of text as you start a program, it
scrolls off the screen with everything else, it doesn't fill up your
drive in log files and I doubt the 250 bytes being sent across the
network for those running remotely is going to chew up anyone's
bandwidth allocation.

I do think that an rc file option (or even a ./configure option if you
want to go that far) is fine for those in the know to adjust to their
tastes - a better option than not show it once a .psql_history exists.

--

Shane Ambler
pgSQL (at) Sheeky (dot) Biz

Get Sheeky @ http://Sheeky.Biz

sfrost@snowman.net (Stephen Frost) writes:

* Peter Eisentraut (peter_e@gmx.net) wrote:

Around <http://archives.postgresql.org/pgsql-patches/2008-01/msg00089.php&gt; it
was proposed to truncate the psql welcome screen. What do you think about
that?

I'd recommend an option in .psqlrc to disable it, if possible. That
would be in line with what alot of other "splash-screen" type things do.

Shorten:

Welcome to psql 8.1.9 (server 8.1.8), the PostgreSQL interactive terminal.

Type: \copyright for distribution terms
\h for help with SQL commands
\? for help with psql commands
\g or terminate with semicolon to execute query
\q to quit

To:

psql 8.1.9 (server 8.1.8) - PostgreSQL interactive terminal
Type: \h for SQL help, \? for psql help, \q to quit

which removes 3/4 of the "bloat," whilst only losing info about
\copyright and \g.

That's close enough to an 80% improvement for me.

That *would* be a big win in doing cut'n'paste of psql sessions, and
while the experienced user may not care about \h, \?, and \q, I'd miss
getting the version information.

There's enough room still there, by the way, that one might cleverly
add in the port number without forcing the addition of an extra line,
which could be useful material, even in a cut'n'paste...
--
(format nil "~S@~S" "cbbrowne" "linuxfinances.info")
http://www3.sympatico.ca/cbbrowne/spiritual.html
Editing is a rewording activity.
-- Alan J. Perlis
[And EMACS a rewording editor. Ed.]

On Thu, 17 Apr 2008 15:58:10 +0200 Peter Eisentraut wrote:

Mike Aubury wrote:

Am I missing something..

$ psql -q testdb
testdb=#

This also quiets out a few other unrelated things.

Like all \timing messages *grumble*

--
Andreas 'ads' Scherbaum
German PostgreSQL User Group

On Thu, 17 Apr 2008 09:30:04 -0400 Stephen Frost wrote:

* Peter Eisentraut (peter_e@gmx.net) wrote:

Around <http://archives.postgresql.org/pgsql-patches/2008-01/msg00089.php&gt; it
was proposed to truncate the psql welcome screen. What do you think about
that?

I'd recommend an option in .psqlrc to disable it, if possible. That
would be in line with what alot of other "splash-screen" type things do.

As long as the default is to display the welcome message, that's ok.
Like Simon explained it would be no good if we change the default
behavior.

Kind regards

--
Andreas 'ads' Scherbaum
German PostgreSQL User Group

On Thursday 17 April 2008 12:04, Joshua D. Drake wrote:

On Thu, 17 Apr 2008 11:11:58 -0400

Andrew Dunstan <andrew@dunslane.net> wrote:

Brendan Jurd wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, Apr 18, 2008 at 12:36 AM, Tom Lane wrote:

Peter Eisentraut writes:

Around it
was proposed to truncate the psql welcome screen. What do you
think about that?

Personally. I'm very seriously against losing the version number
banner. I could do without any of the rest of it.

Currently our prompt is fairly verbose:

Welcome to psql 8.1.10, the PostgreSQL interactive terminal.

Type: \copyright for distribution terms
\h for help with SQL commands
\? for help with psql commands
\g or terminate with semicolon to execute query
\q to quit

We could just do:

psql 8.1.10 - postgresql server version 8.1.10

Type: \h for SQL help, \? for psql help, \q to quit

postgres=#

I think it's getting overlooked because most people don't deal with it, but I
really think we need to keep the SSL info as is. Actually I think we ought
to keep the whole thing and just add the no-splash option for advanced users,
but barring that, the SSL info is very handy when you're working on SSL
enabled servers.

--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL